Test:
- Install NatSkinPlugin
- Put a %COMMENT % on a new page using edit
- Edit the page in compose. Note the comment box appears, not the tag
- Hit save.
- View raw.
The %COMMENT % has been replaced with HTML equivalent.
Tested with SVN 7456 of both Develop and
WysiwygPlugin, installed with pseudo-install.
WysiwygPlugin must be the first plugin in your {PluginsOrder} list. Otherwise
CommentPlugin will turn a COMMENT tag into HTML.
CC
Oooh. Yucky! But thanks
Hmm... Maybe we should allow plugins to announce this after being installed by pseudo-install and in FAILEDPLUGINS?
MC
It turns out that this only happens when
NatSkinPlugin is installed.
MC
I was able to reproduce the error switching on and off the
TwistyPlugin
using only the
WysiwygPlugin,
CommentPlugin,
TablePlugin,
TwistyPlugin in this order.
Some cruft gets into the edit area: some
integers and sometimes stuff that the
addToHEAD()
handler should have added to the head. But things sneak
in deeper. May not be related but the
WysiwygPlugin should use the
addLoadEvent()
mechanism. The
TwistyPlugin
and
NatSkinPlugin both add javascript and load events to the header. That might be a hint on what's going on here.
Changing the "Extension" of this bug item to
WysiwygPlugin.
MD
Nothing to do with the addHEAD. The problem came in two phases:
- There was an assumption (imported from Cairo) that the first call to the commonTagsHandler was always the call that processed the text body. Unfortunately if another plugin called addToHEAD this was no longer true. So this had to be recoded to use the body_text context id (a much better approach anyway)
- Then I discovered that the body_text id was not being reset, so it was still active when the footer was being rendered.
These two problems solved in SVN 4672
CC