• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use

Item7848 for generic doc work for TWiki-6.1.1. Use

Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
• Does this site look broken?. Use the LitterTray web for test cases.

Item7881: VarCachePlugin::_handleVarCache() to avoid direct file access

Item Form Data

AppliesTo:	Component:	Priority:	CurrentState:	WaitingFor:	TargetRelease	ReleasedIn
Extension	VarCachePlugin	Normal	Closed	TWiki:Codev/TWikiFuncGetRevisionInfoTakingMeta	n/a

Detail

VarCachePlugin::_handleVarCache() has the following lines:

# CODE_SMELL: Assume file system for topics
$filename = TWiki::Func::getDataDir() . "/$theWeb/$theTopic.txt";
$topicTime = (stat $filename)[9] || 10000000000;

If TWiki core has TWiki:Codev/TWikiFuncGetRevisionInfoTakingMeta implemented ($TWiki::Plugins::VERSION >= 6.11), TWiki::Func::getRevisionInfo() is supposed to be used with $meta handed.

-- TWiki:Main/HideyoImazu - 2020-01-29

ItemTemplate
Summary	VarCachePlugin::_handleVarCache() to avoid direct file access
ReportedBy	TWiki:Main.HideyoImazu
Codebase	~twiki4
SVN Range	TWiki-6.1.0-trunk, Thu, 29 Aug 2019, build 30672
AppliesTo	Extension
Component	VarCachePlugin
Priority	Normal
CurrentState	Closed
WaitingFor	TWiki:Codev/TWikiFuncGetRevisionInfoTakingMeta
Checkins	TWikirev:30711
TargetRelease	n/a
ReleasedIn

Topic revision: r2 - 2020-01-31 - HideyoImazu

Account
- Log In

Edit
Attach

Item7881: VarCachePlugin::_handleVarCache() to avoid direct file access

Item Form Data

Edit Form Data

Detail