• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item7840: LinkOptionsPlugin class option bug and others

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Extension LinkOptionsPlugin Normal Closed   n/a  

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

LinkOptionsPlugin, which introduces [[URL_or_TOPIC][LABEL][OPTIONS]] notation, has several issues.
  1. Class:CLASS_NAME option is supposed to replace an existing class attribute if it's there. But it adds class="CLASS_NAME" attribute without removing the class attribute an ordinary link has.
  2. It calls TWiki::Func::renderText("[[$link][$text]]") at the beginning of its processing. And it assumes that the return value starts with "<a ". However, there is a case where it starts with "<noautolink><a "
  3. It's written in old style -- "use vars" instead of "our", preferences in the plugin topic. Those oldness should be removed.

-- TWiki:Main/HideyoImazu - 2018-05-22

ItemTemplate
Summary LinkOptionsPlugin class option bug and others
ReportedBy TWiki:Main.HideyoImazu
Codebase

SVN Range TWiki-6.0.2-trunk, Fri, 20 Apr 2018, build 30428
AppliesTo Extension
Component LinkOptionsPlugin
Priority Normal
CurrentState Closed
WaitingFor

Checkins TWikirev:30434 TWikirev:30435
TargetRelease n/a
ReleasedIn

Edit | Attach | Watch | Print version | History: r6 < r5 < r4 < r3 < r2 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r6 - 2018-05-22 - HideyoImazu
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback