• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item7837: Eliminate Monitor.pm

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine Performance Enhancement Closed TWiki:Main.HaraldJoerg patch 6.1.0

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

Performance measurement with Monitor.pm had its value at some point in the past, but today it simply is no match against CPAN:Devel::NYTProf.

I suggested to remove our own monitor in TWiki:Codev/EliminateMonitorDotPm and such was agreed at TWiki:Codev/KampalaReleaseMeeting2018x02x01.

Trivia:

  • The speedup of "normal" TWiki operation by eliminating the calls to Monitor is tiny but visible in Devel::NYTProf (about 0.1%).
  • If you wonder about the strange name "NYTProf": The work on the initial fork of this profiler from Devel::FastProf has been sponsored by the New York Times, and the name stuck since then.

-- TWiki:Main/HaraldJoerg - 2018-02-06

The two checkins are for the core components and for the default plugins. Within SVN, there are a few non-default extensions which were once prepared to use Monitor.pm, but in all cases it is commented out. So, no action is required for these extensions (and IMO the deletion of comments doesn't justify a new version). We should be done right now.

These are the extensions with inactive uses of Monitor:

-- TWiki:Main.HaraldJoerg - 2018-02-06

...needed another commit, I forgot two core files.

-- TWiki:Main.HaraldJoerg - 2018-02-06

... and now Monitor.pm has to go, finally

-- TWiki:Main.HaraldJoerg - 2018-07-09

ItemTemplate
Summary Eliminate Monitor.pm
ReportedBy TWiki:Main.HaraldJoerg
Codebase ~twiki4, 6.0.2
SVN Range TWiki-6.0.2-trunk, Fri, 03 Nov 2017, build 30403
AppliesTo Engine
Component Performance
Priority Enhancement
CurrentState Closed
WaitingFor TWiki:Main.HaraldJoerg
Checkins TWikirev:30420 TWikirev:30421 TWikirev:30422 TWikirev:30529
TargetRelease patch
ReleasedIn 6.1.0
Edit | Attach | Watch | Print version | History: r12 < r11 < r10 < r9 < r8 | Backlinks | Raw View |  Raw edit | More topic actions
Topic revision: r12 - 2018-07-17 - PeterThoeny
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2024 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback