• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7700 for generic doc work for TWiki-6.0.2. Use View topic Item7703 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item7799: TWiki with current Perl: Eliminate warnings

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine   Normal Waiting for Release TWiki:Main.HaraldJoerg major  

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

This is a collection of warnings which pop up during tests for TWiki under Perl 5.24. It turns out that a couple of warnings were present (but ignored) in earlier versions, too.
  • Possible precedence issue with control flow operator at /linuxdevel/twiki/trunk/core/lib/TWiki/Attach.pm line 226.
    • This is somewhat serious: The line in question reads return $info->{attr} or " ";. This has always been equivalent to return $info->{attr}; because return has higher precendence than or. The warning came up in Perl 5.20.
    • Since this bad line has apparently been working for ages I'll simply drop the or clause.
    • Done in Rev. 30334. -- TWiki:Main/HaraldJoerg - 2017-05-26
  • Useless use of greediness modifier '?' ... at trunk/core/lib/TWiki/Store/RcsLite.pm line 302.
    • Another new warning in Perl 5.20. I guess it slipped through since RcsLite is rarely used in production. I am using RcsLite quite regularly in my TWikis on Windows and haven't seen any bad effects, and I don't understand what the greediness modifier was supposed to do at all. Therefore I'll simply eliminate it.
    • Done in Rev. 30335. -- TWiki:Main/HaraldJoerg - 2017-05-26
  • Unescaped left brace in regex is deprecated, passed through in regex; ... at CommentPlugin/CommentPluginTests.pm line 224 , 226
    • A special case since the left brace comes in through a variable, so replacing { with \{ isn't applicable. The method \Q$var\E works.
  • TWiki::I18N::_normalize_language_tag should not issue a warning if there's no predefined language

-- TWiki:Main/HaraldJoerg - 2017-04-10

ItemTemplate
Summary TWiki with current Perl: Eliminate warnings
ReportedBy TWiki:Main.HaraldJoerg
Codebase ~twiki4
SVN Range TWiki-6.0.2-trunk, Fri, 07 Apr 2017, build 30318
AppliesTo Engine
Component

Priority Normal
CurrentState Waiting for Release
WaitingFor TWiki:Main.HaraldJoerg
Checkins TWikirev:30327 TWikirev:30335 TWikirev:30336
TargetRelease major
ReleasedIn

Edit | Attach | Watch | Print version | History: r5 < r4 < r3 < r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r5 - 2017-05-25 - HaraldJoerg
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2017 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback