• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item7535: Various patches to unit tests

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Extension UnitTests Normal Closed   n/a 6.0.1

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

A couple of unit tests need to be adjusted to changes in TWiki code:
  • CommentPlugin/CommentPluginTests.pm: Needs to explicitly disable the CryptToken .
  • ExceptionTests.pm, RenameTests.pm,StoreSmokeTests.pm: The new oops mechanism had all its templates renamed to oops*, but test cases have been not adapted accordingly.
  • ResponseTests.pm: At some point in time, TWiki::Response::headers decided to add a Date header, which has not been accounted for in the unit test.
  • SaveScriptTests.pm: Needs to re-read the topic after creating a new TWiki object so that asserts have access to the data.
  • TocTests.pm: setup needs to be adapted to the changes by Item7286.
  • TWikiFnTestCase.pm: When creating temporary webs, the users web must be created before other webs because WatchlistPlugin (enabled per default) wants to read user preferences.
  • TimeTests.pm makes the assumption that Paris is always GMT+1 which fails in Summer. Can be fixed by chosing a location which does not have daylight saving time.
  • RenderFormTests.pm wasn't right with label type field.

These might need another look, please revert if considered inappropriate:

  • ConfigureTests.pm: The tests for regexes as configuration items had a special handling for "versions less than Perl v5.14" - but apparently Perl v5.18 behaves like the old ones.
  • PasswordTests.pm and TWiki/Users/HtPasswdUser.pm: The module Digest::SHA1 seems to be unavailable in recent Linux distributions, Digest::SHA is a drop-in replacement.
  • StoreTests.pm: Makes the assumption that hashes with identical keys will return them in the same order - which is no longer valid in Perl v5.18. I chose to change TWiki::Meta::stringify to always return keys in a defined (sorted) order.
-- TWiki:Main/HaraldJoerg - 2014-07-18

ItemTemplate
Summary Various patches to unit tests
ReportedBy TWiki:Main.HaraldJoerg
Codebase ~twiki4
SVN Range TWiki-6.0.1-trunk, Sun, 15 Jun 2014, build 27651
AppliesTo Extension
Component UnitTests
Priority Normal
CurrentState Closed
WaitingFor

Checkins TWikirev:27855 TWikirev:27856 TWikirev:28185 TWikirev:28186 TWikirev:28199 TWikirev:28200
TargetRelease n/a
ReleasedIn 6.0.1
Edit | Attach | Watch | Print version | History: r9 < r8 < r7 < r6 < r5 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r9 - 2014-10-05 - HideyoImazu
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2020 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback