• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7700 for generic doc work for TWiki-6.0.2. Use View topic Item7703 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item7430: DONTNOTIFYCHECKBOX no longer works

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Extension PatternSkin Normal Confirmed   n/a  

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

The preference is documented to indicate whether a topic save is 'quiet' ('minor') by default.

This is important for topics such as 'webnotify'.

The checkbox was removed from the GUI a long time ago and replaced with a 'quiet save' button. This was a mistake.

See discussion at http://twiki.org/cgi-bin/view/Codev/TopicPreferenceForQuietSaves and http://twiki.org/p/pub/Codev/KampalaReleaseMeeting2014x02x06/KampalaMeetingLog2014x02x06.txt

The checkbox needs to be put back, and again take its default from DONTNOTIFYCHECKBOX preference (so old webs/topics work).

Suggestion that a new name with a true/false argument would be better is OK going forward.

-- TWiki:Main/TimotheLitt - 2014-02-07

Note: 'Watch' is missing on TopMenu and greyed-out on the bottom action list. Something needs updating.

-- TWiki:Main.TimotheLitt - 2014-02-07

FYI, if you are logged out the Watch is missing/grayed out.

-- TWiki:Main.PeterThoeny - 2014-02-07

The checkbox has vanished from PatternSkin, but the parameter dontnotify is still evaluated by the save skript, I've changed "Applies To " and "Component" accordingly.

Worse: The documentation at TWiki:TWiki.DontNotify describes the preference variable but does not tell what value(s) should be given.

My idea is to just add a hidden input field and pass the content of DONTNOTIFYCHECKBOX as its value - that would be a one-line change in the template edit.pattern.tmpl. However, other skins just interpolate DONTNOTIFYCHECKBOX in the input type="checkbox" name="dontnotify" element, so it would sort of "work" with values like "checked" or 'checked' but also checked='checked' and checked="checked". There's no trivial way to interpolate all of these into a valid value attribute of a hidden control, but this might still be a viable solution.

I sort of agree with Timothe that another preference variable with a true/false value would be a good idea, but this breaks all existing skins.

-- TWiki:Main.HaraldJoerg - 2017-12-21

Decided at TWiki:Codev.KampalaReleaseMeeting2017x12x21 to reprioritize to "normal".

-- TWiki:Main.PeterThoeny - 2017-12-21

Recommend as per TWiki:Codev.KampalaReleaseMeeting2014x02x06 to replace "Quiet save" button with previously used checkbox.

-- TWiki:Main.PeterThoeny - 2017-12-21

ItemTemplate
Summary DONTNOTIFYCHECKBOX no longer works
ReportedBy TWiki:Main.TimotheLitt
Codebase 6.0.0, 5.1.4, 5.1.3, 5.1.2, 5.1.1, 5.1.0, 5.0.2, 5.0.1, 5.0.0, 4.3.2, 4.3.1, 4.3.0, 4.2.4, 4.2.3, 4.2.2, 4.2.1
SVN Range TWiki-6.0.1-trunk, Thu, 09 Jan 2014, build 26720
AppliesTo Extension
Component PatternSkin
Priority Normal
CurrentState Confirmed
WaitingFor

Checkins

TargetRelease n/a
ReleasedIn

Edit | Attach | Watch | Print version | History: r4 < r3 < r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r4 - 2017-12-21 - PeterThoeny
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback