• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item6984: The WEBLIST in AdminToolsCategory is currently broken in trunk.

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine   Normal Closed   n/a  

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

The AdminToolsCategory is currently broken in trunk. Screenshot:

web-report-bug.png

The issue is only in trunk, same report works properly in the 5.1 branch, e.g. it is a code issue, not a WEBLIST usage issue.

-- TWiki:Main/PeterThoeny - 2012-10-14

This is fixed now.

Currently special strings in the format parameters are handled as follows.

  • $web and $name need to be at a word boundary (\b) to be expanded. $web1 and $name1 are not expanded.
  • $marker, $qname, $indentedname don't have be at a word boundary to be expanded.
Is there a way to avoid this inconsistency?

Now that FormatTokens can be used (r23518 onward), we can make the behaviors of $marker, $qname, and $indentedname consistent with $web and $name without sacrificing expressiveness - $marker$nopSOMETHING.

I understand compatibility matters. But I wonder what you think, Peter.

-- TWiki:Main.HideyoImazu - 2012-10-15

Looking at SEARCH, it has lots of variables that do not require word boundaries:

                    $out = $format;
                    $out =~ s/\$web/$web/gs;
                    $out =~ s/\$topic\(([^\)]*)\)/TWiki::Render::breakName( $topic, $1 )/ges;
                    $out =~ s/\$topic/$topic/gs;
                    $out =~ s/\$date/$revDate/gs;
                    $out =~ s/\$isodate/$isoDate/gs;
                    $out =~ s/\$rev/$revNum/gs;
                    $out =~ s/\$wikiusername/$wikiusername/ges;
                    $out =~ s/\$ntopics/$ntopics/gs;
                    $out =~ s/\$nhits/$nhits/gs;
                    $out =~ s/\$wikiname/$wikiname/ges;

I recommend to stay compatible.

BTW, I don't like the syntax for $qname because one could write as well "$name", e.g. overkill. Same with $indentedname, it clobbers indent and topic name, so it is not easy to create custom link formats with indents. For inconsistent variables like these I recommend to retire them by keeping feature as undocumented feature, and to introduce new variables that are more consistent.

-- TWiki:Main.PeterThoeny - 2012-10-16

Thanks, that fixed another issue: The Home pulldown menu show gray web color for all webs instead of actual web colors.

-- TWiki:Main.PeterThoeny - 2012-10-16

I am setting this to "Closed" since it was a bug introduced and fixed in trunk only, e.g. not to be announced in a release.

-- TWiki:Main.PeterThoeny - 2012-12-15

ItemTemplate
Summary The WEBLIST in AdminToolsCategory is currently broken in trunk.
ReportedBy TWiki:Main.PeterThoeny
Codebase ~twiki4
SVN Range

AppliesTo Engine
Component

Priority Normal
CurrentState Closed
WaitingFor

Checkins TWikirev:23651
TargetRelease n/a
ReleasedIn

Topic attachments
I Attachment History Action Size Date Who Comment
PNGpng web-report-bug.png r1 manage 75.4 K 2012-10-14 - 05:08 PeterThoeny  
Edit | Attach | Watch | Print version | History: r10 < r9 < r8 < r7 < r6 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r10 - 2012-12-15 - PeterThoeny
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback