• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item6446: $viewfileUrl does not give the current version.

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Extension AttachmentListPlugin Normal New   n/a  

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

-- TWiki:Main/SeanLazar - 06 May 2010

I have found a bug in AttachmentListPlugin.pm:

$viewfileUrl does not give the current version. rev= in the URL always appears empty.

Line 397 needs to be changed.

Line 397 as it is now:

            my $attrVersion = $fileData->{attachment}->{Version} || '';

Should be changed to:

            my $attrVersion = $fileData->{attachment}->{version} || '';

Relevant code block:

        if ( $s =~ m/\$viewfileUrl/ ) {
            my $attrVersion = $fileData->{attachment}->{Version} || '';
            my $viewfileUrl =
              TWiki::Func::getScriptUrl( $fileData->{web}, $fileData->{topic},
                "viewfile" )
              . "?rev=$attrVersion&filename=$fileData->{name}";
            $s =~ s/\$viewfileUrl/$viewfileUrl/g;
        }

-- TWiki:Main/SeanLazar - 06 May 2010

Thanks Sean! See my comment in TWiki:Plugins/AttachmentListPluginDev.

-- TWiki:Main.PeterThoeny - 06 May 2010

ItemTemplate
Summary $viewfileUrl does not give the current version.
ReportedBy TWiki:Main.SeanLazar
Codebase 4.3.1
SVN Range TWiki-5.0.0-rc1, Mon, 03 May 2010, build 18580
AppliesTo Extension
Component AttachmentListPlugin
Priority Normal
CurrentState New
WaitingFor

Checkins

TargetRelease n/a
ReleasedIn

Edit | Attach | Watch | Print version | History: r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r2 - 2010-05-06 - PeterThoeny
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback