Item6128: Login names with dots not working properly

We are using the ApacheLogin login manager in our environment. Some users have a DOT in their login names (e.g., first.last). When one of these users edits a topic and saves, the topic author gets set to the cUID and when TWiki displays the author on the topic page it displays the cUID not the twiki name nor the login name. This transformation appears to occur in the mapLogin2cUID function in Users.pm.

I have temporarily changed the line from

    $cUID =~ s/([^a-zA-Z0-9])/'_'.sprintf('%02x', ord($1))/ge;

to

    $cUID =~ s/([^a-zA-Z0-9.])/'_'.sprintf('%02x', ord($1))/ge;
 

Notice the DOT added to the matching statement.

Without this change, the login gets transformed from something like first.last to first_2elast.

I saw this issue reference in Item5118 as having been fixed and it was working fine in Rev 17004 but then stopped working in Rev 17022, the next change that was checked in for Users.pm

Should I stay with my change? What consequences should I look for?

-- TWiki:Main/DougCampbell - 19 Nov 2008

Hi - TWiki:Main/DougCampbell

Not able to replicate this problem on "Revision 17728" release branch. Tried your suggested changes to the code- does not make any difference.

-- SopanShewale - 23 Nov 2008

On further review, I have discovered that this problem is created by myself I had developed an auto-registration plugin and I was using the login not cUID for creating the user.

Thanks!

-- TWiki:Main.DougCampbell - 24 Nov 2008

Actually, it turns out that this is still a problem. If I remove my plugin for auto-registration, things continue not to work properly. One thing I would like to note is that the topic meta data seems to store the cUID and not the loginname. I'm I correct in stating this? If so, what happens is that when I save a topic, the meta data for a DOTTED name gets written as "given_2elast" and when TWiki goes to later on when displaying try to display this back as a WikiName, it can't because it treats this a loginname and it can't find given_2elast in the users page, only given.last.

-- DougCampbell - 24 Nov 2008

Re-prioritized from urgent to normal at TWiki:Codev/GeorgetownReleaseMeeting2008x11x24

-- TWiki:Main.PeterThoeny - 25 Nov 2008

Are you at least acknowledging that this is an issue? The notes from your release meeting seem to indicate you think it isn't. To me it appears to be fairly serious so I was just wondering if I could get some clarification. Thanks!

-- TWiki:Main.DougCampbell - 30 Nov 2008

Yes, it looks like an issue that needs to be fixed.

-- TWiki:Main.PeterThoeny - 02 Dec 2008

Thanks Peter! I will keep my eyes open for the fix. Appreciate it.

-- TWiki:Main.DougCampbell - 03 Dec 2008