• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item6082: deep recursion bug in query search

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine   Normal Confirmed   n/a 5.1.4, 4.2.4

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

from TWiki:Support.DeepRecursionUsingFormfieldInForm

Question

Hello,

if I use a query search in a form to generate a value list and in the format is a $formfield I get a deep recursion. My TWiki Version is 4.2.3

The search string:

%SEARCH{ "HardwareInventoryForm.MachineTypeName~'*BladeCenter*'" type="query" scope="text" nonoise="on" order="topic" format="$formfield(MachineName)" seperator=", "}%

Here is what the apache error log shows: http://tobias.vdkrone.de/files/apache_error

Environment

TWiki version: TWikiRelease04x02x02
TWiki plugins: DefaultPlugin, EmptyPlugin, InterwikiPlugin, ActionTrackerPlugin, RackPlannerPlugin, RenderListPlugin,
Server OS: RHEL 5.2, kernel 2.6.18-92.1.10.el5
Web server: Apache/2.2.3
Perl version: v5.8.8
Client OS: Ubuntu 7.10
Web Browser: Firefox 3.0.2
Categories: Forms, Search %SUPPORTCATEGORIES%

-- TWiki:Main.TobiasVonDerKrone - 15 Oct 2008

-- TWiki:Main/SvenDowideit for TWiki:Main.TobiasVonDerKrone - 18 Oct 2008

It looks like it may be a recursive tag expansion (though how it's managing to defeat the recursion block I'm not sure). We'd really need the topic, or a simplified version of it, to be able to debug this.

-- CrawfordCurrie - 20 Oct 2008

I posted an example in http://twiki.org/cgi-bin/view/Support/DeepRecursionUsingFormfieldInForm

-- TWiki:Main.TobiasVonDerKrone - 20 Oct 2008

Reproducible on 4.2.3, but not on 4.2.x or trunk. Confirmed. Has anyone changed the search result formatting code? It looks like there was a recursion in there.

-- TWiki:Main.CrawfordCurrie - 21 Oct 2008

I did two more tests:

-- TWiki:Main.TobiasVonDerKrone - 21 Oct 2008

I have a web which is shared between all my installs, and I can't reproduce it on TWikiRelease04x02 or trunk (both at 17701), which suggests it may be related to the configuration.

-- TWiki:Main.CrawfordCurrie - 27 Oct 2008

Tobias, I suspect you weren't really running against those versions. I ran the testcase manually, and then added unit tests to both TWikiRelease04x02 and trunk. The test definitely reproduces the failure in the expected way when run against 4.2.3, but passes clean with TWikiRelease04x02 and trunk. So I consider this fixed. If you can find a flaw in what i have done, please re-open the report.

-- CrawfordCurrie - 27 Oct 2008

Thanks. I will check this again next week and give a comment.

-- TWiki:Main.TobiasVonDerKrone - 28 Oct 2008

FYI I found that this is actually a genuine bug; the unit tests fail when they are run outside my dev environment, so I have re-opened it.

-- CrawfordCurrie - 29 Oct 2008

Modified lib/TWiki/Search.pm for this.

Committed revision 17730 - for Release Branch.

Committed revision 17729. for trunk

-- SopanShewale - 23 Nov 2008

Closing After Release 4.2.4

-- SopanShewale - 11 Dec 2008

As of 2013-02-08 r24902, this bug is there. FormDefTests::test_Item6082() causes deep recursion error.

-- Hideyo Imazu - 2013-02-08

Re-occuring bug tracked in Item7146.

-- TWiki:Main.PeterThoeny - 2013-02-15

ItemTemplate
Summary deep recursion bug in query search
ReportedBy TWiki:Main.TobiasVonDerKrone
Codebase ~twiki4, 4.2.3
SVN Range TWiki-5.0.0, Sun, 05 Oct 2008, build 17588
AppliesTo Engine
Component

Priority Normal
CurrentState Confirmed
WaitingFor

Checkins TWikirev:17706 TWikirev:17729 TWikirev:17730
TargetRelease n/a
ReleasedIn 5.1.4, 4.2.4
Edit | Attach | Watch | Print version | History: r19 < r18 < r17 < r16 < r15 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r19 - 2013-02-15 - PeterThoeny
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback