• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item5800: usermapping changes are currently broken.

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine   Urgent Closed   patch 4.2.1, 5.0.0

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

I've just started poking the changes you made to get an idea of how my many usermappers need to be changed, and here's the first issues i have noticed:

Users.pm
=pod

---++ ObjectMethod checkPassword( $cUID, $passwordU ) -> $boolean

Finds if the password is valid for the given user.

Returns 1 on success, undef on failure.

TODO: add special check for BaseMapping admin user's login, and if
its there (and we're in sudo_context?) use that..

=cut

sub checkPassword {
    my ( $this, $cUID, $pw ) = @_;
    return $this->_getMapping($cUID)->checkPassword( $cUID, $pw );
}

UserMapping.pm:
=pod

---++ ObjectMethod checkPassword( $login, $passwordU ) -> $boolean

Finds if the password is valid for the given user. This is called using
a login name rather than a cUID because the user may not have been mapped
at the time it is called.

Returns 1 on success, undef on failure.

Default behaviour is to return 1.

=cut

sub checkPassword {
    return 1;
}

Giving a good reason why the mapping_prefix should be set to non-'' for unit testing at least.

unfortunately, setting $this->{mapping_id} = 'TWikiUserMapping_'; in the constructor shows there are quite alot of things that don't work correctly.

I've also not found the release not docco that will be needed to let people know what they have to change in their custom usermappers - cos its not obvious because of the formatting changes.

-- TWiki:Main/SvenDowideit - 22 Jul 2008

Sorry, I don't understand. As far as I can make out you are saying checkPassword must work before the user mapping is enabled; but if that were the case, surely the tests and interactive usage would fail? Judging from unit testing and interactive testing, the checkPassword is working fine, for normal users and admin users. At what point is it called prior to the mappings being enabled?

-- CrawfordCurrie - 23 Jul 2008

If you re-enable the cUID prefix, you will see that they do fail. If you test using a mapping system where the cuid is not the same as the login, it does fail.

-- TWiki:Main.SvenDowideit - 24 Jul 2008

OK. I added fixture groups for a number of the low level tests, but I am not confident of the coverage. However they did show up what you were talking about, and I have addressed the problems. I'm going to leave this open for your feedback until you have looked at one of the named mappers.

-- CrawfordCurrie - 24 Jul 2008

I've been feeding into Crawford's paranoia about this, and http://twiki.org/cgi-bin/view/Codev/UserMapperChangesBetween420And421 is a part of the response. Thus far my testing suggests that things are much better now - but time will tell.

-- SvenDowideit - 28 Jul 2008

According to my sources Michael will not be able to respond before the 4.2.1 release 03 Aug 2008. And I know of no other mapping authors having shared work related that will respond here.

So we have to rely on your judgement Sven.

I will flip this to Closed and we will need to take further problems as they come in a 4.2.2 in a new bug item in case Michael has issues when he returns.

There is nothing that prevents a quick 4.2.2 with a few mapping fixes as follow up. But we are many that want the fixes already made in the code including the important authentication and security fixes out in a release now and not wait another 1-2 months which I fear this can turn into.

-- KennethLavrsen - 28 Jul 2008

Hmmm.. sounds interesting - let me develop my interest in this system. I am trying to understand what's happening here...if i find something interesting, i will provide the feedback.

-- TWiki:Main.SopanShewale - 28 Jul 2008

Cleaned "WaitingFor" field.

-- TWiki:Main.GilmarSantosJr - 10 Aug 2008

ItemTemplate
Summary usermapping changes are currently broken.
ReportedBy TWiki:Main.SvenDowideit
Codebase 4.2.0, ~twiki4
SVN Range TWiki-5.0.0, Mon, 21 Jul 2008, build 17093
AppliesTo Engine
Component

Priority Urgent
CurrentState Closed
WaitingFor

Checkins TWikirev:17131 TWikirev:17132 TWikirev:17174 TWikirev:17175
TargetRelease patch
ReleasedIn 4.2.1, 5.0.0
Edit | Attach | Watch | Print version | History: r12 < r11 < r10 < r9 < r8 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r12 - 2008-08-10 - GilmarSantosJr
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback