• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item5787: square bracket url links don't escape their contents well enough

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine   Low Closed   patch 4.2.1, 5.0.0

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

if you have a [<nop>[url][text]] link that specifies a url with spaces in it, the link works ok.

Except, if that spaced Url contains a WikiWord. then the url is broken because the link contains another link.

for eg

  1. testing the file
  2. putting a WikiWord in the text
  3. putting a WebHome in the text

-- TWiki:Main/SvenDowideit - 17 Jul 2008

i presume it should really urlencode things too..

-- TWiki:Main.SvenDowideit - 17 Jul 2008

What about this:

testing the file

Using a well-formed URL seems to work.

-- RafaelAlvarez - 21 Jul 2008

This is not a bug because [[http://home.org.au/Some FileName that looks interesting.jpg][testing the file]] is an illegal URL. Spaces need to be escaped with + or %20.

-- TWiki:Main.PeterThoeny - 21 Jul 2008

it is a bug - though a low one. TWiki produces a bad rendered output, and in fact, TWiki should be the one to do the escaping. There is no reason why a URL that works in the browser should not at least be attempted to work properly in TWiki.

Non-technical users should not be expected to know the standard, and they sure as heck are not going to work out unassisted that the url they got from firefox (and works there) is somehow non-standards-compliant.

-- SvenDowideit - 22 Jul 2008

URL from Firefix with spaces? The minute you hit enter FF inserts %20.

This is not a release blocker. As agree in TWiki:Codev.GeorgetownReleaseMeeting2008x07x21.

if you want TWiki to auto generate %20 then fine. But then it is either Low priority or Enhancement. I see it is already set low. I am OK with that as long as it does not block 4.2.1.

-- TWiki:Main.KennethLavrsen - 22 Jul 2008

not all versions of firefox do this then - I've been using firefox 3, and it is not inserting %20's - it is showing me a much more user friendly url.

-- TWiki:Main.SvenDowideit - 22 Jul 2008

True. This has changed from FF 2 to FF3. Just tried. FF3 still pads with %20 in the actual URL but displays spaces.

If you fix this please remember that [[URL text]] is supposed to work displaying text. It is only in the [[URL][text]] case we can pad with %20.

Example TWiki

-- TWiki:Main.KennethLavrsen - 22 Jul 2008

is it supposed to work for =[[wikiword text]] ?

evidently not. what a bizarre mis-feature.

-- TWiki:Main.SvenDowideit - 01 Aug 2008

I checked back to Cairo if the [[wikiword text]] worked and if we have since broken it.

But it was not a feature in Cairo either so it is a bizarre mis-feature that only works with URLs

-- TWiki:Main.KennethLavrsen - 01 Aug 2008

ItemTemplate
Summary square bracket url links don't escape their contents well enough
ReportedBy TWiki:Main.SvenDowideit
Codebase 4.2.0, 4.2.1, ~twiki4
SVN Range TWiki-5.0.0, Tue, 15 Jul 2008, build 17022
AppliesTo Engine
Component

Priority Low
CurrentState Closed
WaitingFor

Checkins TWikirev:17250 TWikirev:17251
TargetRelease patch
ReleasedIn 4.2.1, 5.0.0
Edit | Attach | Watch | Print version | History: r12 < r11 < r10 < r9 < r8 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r12 - 2008-08-04 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback