• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item5677: META tag does not show form field data in 4.2

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine   Normal Closed   patch 4.2.1, 5.0.0

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

I intially asked this in the support web http://twiki.org/cgi-bin/view/Support/METAformfieldDisplayBroken

After upgrading from 4.1.2 to 4.2, META tags for form fields came up blank and didn't work

 

Looking in the Twiki.pm for 4.2 shows that the function that renders the formfield has changed from 4.1

I was able to restore functionality using the following change:

--- lib/TWiki.pm 2008-04-23 13:06:50.000000000 +1000
+++ lib/Twiki.pm.orig   2008-04-23 13:37:42.000000000 +1000 @@ -3795,7 +3795,7 @@
          return $meta->renderFormForDisplay( $this->templates );
      } elsif ( $option eq 'formfield' ) {
          # a formfield from within topic text 
-        return $meta->renderFormFieldForDisplay( $params->{'name'}, '$value' ); 
+        return $meta->renderFormFieldForDisplay( $params );
      } elsif( $option eq 'attachments' ) {
          # renders attachment tables
          return $this->attach->renderMetaData( $web, $topic, $meta, $params ); 

So I have some questions:

  • Is this a Bug?
  • Is this a good fix for it?
  • Should the fix be on the renderFormFieldForDisplay function in Meta.pm and not the Twiki.pm?
    • The renderFormFieldForDisplay function appears to be called correctly from /ActionTrackerPlugin/Action.pm and the Search.pm.

-- TWiki:Main/SimonHarrison - 03 Jun 2008

odd - I'll have to look into why it was changed.

-- TWiki:Main.SvenDowideit - 03 Jun 2008

http://develop.twiki.org/trac/changeset/16770

-- TWiki:Main.CrawfordCurrie - 03 Jun 2008

What Crawford means to say, is that this has already been patched for 4.2.1 - though I'm surprised that Item4741 didn't examine the root cause.

-- TWiki:Main.SvenDowideit - 03 Jun 2008

Sorry, I was a bit terse there.... smile

-- TWiki:Main.CrawfordCurrie - 03 Jun 2008

and so presumably, its fixed smile

-- SvenDowideit - 25 Jun 2008

ItemTemplate
Summary META tag does not show form field data in 4.2
ReportedBy TWiki:Main.SimonHarrison
Codebase 4.2.0
SVN Range

AppliesTo Engine
Component

Priority Normal
CurrentState Closed
WaitingFor

Checkins

TargetRelease patch
ReleasedIn 4.2.1, 5.0.0
Edit | Attach | Watch | Print version | History: r7 < r6 < r5 < r4 < r3 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r7 - 2008-08-04 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback