• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item5664: Wysiwyg is eating newlines after last bullet in FF and if no white space line after bullet

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Extension WysiwygPlugin Urgent Closed   patch 4.2.1

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

To reproduce this you need

  • Firefox running under windows XP
  • Some Bullets And a line right after the bullet with no empty line after the bullet like this one

or same inside verbatim

   * Firefox running under windows XP
   * Some Bullets
And a line right after the bullet with no empty line after the bullet like this one

Create this in raw edit

And then you need to edit and save the topic in the Wysiwyg editor.

What I see it that the line after the last bullet is now on the last bullet. What happens is that the Wysiwyg editor adds one space before the text of the line after the last bullet. This makes the tine rendered as part of the bullet above. With one more edit/save cyckle in wysiwyg the newline is also gone and the line below the last bullet is now an integrated part of the last bullet

The problem is the little space that is inserted before the text after the last bullet. And this only happens in Firefox

I have been testing the wysiwyg feature with the current SVN code on a lot of real topics and I had many topics that were damaged by this bug. So it is a release blocker.

-- TWiki:Main/KennethLavrsen - 29 May 2008

I am now editing the bug in FF and will now save. The bullets and text line still looks OK in the TMCE editor before the save.

KJL

Note how the text "And a line right after the bullet with no empty line after the bullet like this one" has crept up next to the text "Some Bullets" after editing twice

-- TWiki:Main.KennethLavrsen - 29 May 2008

Anything I can do to analyse this bug? I want to update my Wysiwyg asap but this silly bug is the only thing that prevents it.

-- TWiki:Main.KennethLavrsen - 03 Jun 2008

I can reproduce this. Confirmed. Requires detailed analysis of the HTML generated by firefox, generation of a unit testcase, and fixing.

-- CrawfordCurrie - 04 Jun 2008

I have done some analysis.

It is the code change in TWikirev:16058 that introduced the problem.

This is a change to the twiki_tiny.js only.

I do not understand at all what this change does. I do not know javascript at all. But I hope my analysis help getting nearer a resolution.

Note also that you cannot just use the old version of twiki_tiny.js with current SVN version of TMCE. Additional later changes are incompatible with the old version of the js file. What I am noting is exactly which change introduced this bug as a help to a resolution.

-- TWiki:Main.KennethLavrsen - 10 Jun 2008

OK, thank you for the analysis, very helpful. I probably set cleanup false originally for exactly this reason. Item5138 was "cured" before the more recent understanding of encoding took root, and I suspect that the analysis that drove that fix was incorrect.

-- TWiki:Main.CrawfordCurrie - 10 Jun 2008

I did the simplest thing, and performed an un-cleanup in the perl.

-- CrawfordCurrie - 10 Jun 2008

Closing as the bug did not manifest itself in 4.2.0 but was introduced after. So it should not need to go in 4.2.1 release note.

The fix works great which means that the plugin as it is now is a great replacement for the 4.2.0 version as long as you do not run utf-8

Thanks for the fix. It will make a lot of my users happy now that they get all the other bugfixes accumulated when I upgrade later today.

-- KennethLavrsen - 11 Jun 2008

ItemTemplate
Summary Wysiwyg is eating newlines after last bullet in FF and if no white space line after bullet
ReportedBy TWiki:Main.KennethLavrsen
Codebase 4.2.1
SVN Range TWiki-5.0.0, Tue, 27 May 2008, build 16846
AppliesTo Extension
Component WysiwygPlugin
Priority Urgent
CurrentState Closed
WaitingFor

Checkins TWikirev:16887 TWikirev:16888 TWikirev:16889
TargetRelease patch
ReleasedIn 4.2.1
Edit | Attach | Watch | Print version | History: r10 < r9 < r8 < r7 < r6 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r10 - 2008-06-11 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback