• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item5560: FormPlugin: calendar button invisible if there are no twisties on the same page

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Extension FormPlugin Urgent New   n/a  

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

This plugin surrounds the calendar button with a span of this kind:
<span class="twikiMakeVisible"
...
</span>

The twikiMakeVisibleXXX classes are hidden by default CSS and only exposed if there is a TWISTY on the same page, which would then trigger the twikiMakeVisibleXXX tags to be uncovered. Outchie.

The solution for now is to remove this extra span:

--- lib/TWiki/Plugins/FormPlugin.pm     (revision 16706)
+++ lib/TWiki/Plugins/FormPlugin.pm     (working copy)
@@ -1383,7 +1383,6 @@
               || $TWiki::cfg{JSCalendarContrib}{format}
               || "%e %B %Y";

-            $text .= ' <span class="twikiMakeVisible">';
             my $control = CGI::image_button(
                 -class   => 'editTableCalendarButton',
                 -name    => 'calendar',
@@ -1398,7 +1397,6 @@
             #fix generated html
             $control =~ s/MIDDLE/middle/go;
             $text .= $control;
-            $text .= '</span>';
         }
     };
     return $text;

Arthur, can you please comment on the use of the twikiMakeVisibleXXX and similar CSS classes, i.e. if there are no TWISTIES on the same page.

-- TWiki:Main/MichaelDaum - 22 Apr 2008

twikiMakeVisible CSS classes are meant to not show interface parts that rely on javascript (regardless of a TWISTY tag). But since we also have a guideline to not make default skin rely on javascript, these CSS classes are not in default skin, only in pattern skin.

In css.pattern.tmpl I have this:

%TMPL:DEF{"javascriptaffectedstyle"}%<script type="text/javascript" src="%PUBURLPATH%/%SYSTEMWEB%/TWikiJavascripts/twikiStyles.js"></script>%TMPL:END%

-- TWiki:Main.ArthurClemens - 02 May 2008

Hm, does only work on 4.2. Can't we dismiss this css-js interaction?

-- TWiki:Main.MichaelDaum - 06 May 2008

ItemTemplate
Summary FormPlugin: calendar button invisible if there are no twisties on the same page
ReportedBy TWiki:Main.MichaelDaum
Codebase

SVN Range TWiki-5.0.0, Tue, 15 Apr 2008, build 16676
AppliesTo Extension
Component FormPlugin
Priority Urgent
CurrentState New
WaitingFor

Checkins

TargetRelease n/a
ReleasedIn

Edit | Attach | Watch | Print version | History: r3 < r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r3 - 2008-05-06 - MichaelDaum
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback