Item5287: Linking is totally broken - in 4.2 WikiWord links do not work - in 4.1.2 buttons are disabled

I've installed the latest versions (as of today) of TWiki:Plugins/TinyMCEPlugin and TWiki:Plugins/WysiwygPlugin on TWiki 4.1.2. I don't know whether it has anything to do with it but there is also TWiki:Plugins/NatEditContrib installed on the system. I adjusted the template according to the FAQ to have the "old" behaviour with two buttons for editing.

When using Firefox 2.0.11 to edit a topic with TinyMCE, the save and cancel buttons works fine - unless I insert a link using the chain button (maybe there are also other ways to trigger this error). After having done that, the four buttons at the top (save, cancel etc.) all give the same JS error:

 
vbls is not defined

in twiki_tiny.js, line 18.

To leave the editing mode, I have to use the back button (thereby losing all the changes).

In IE, the situation is even worse (lots of JS errors, all the NatEdit buttons are still shown at the top etc.) - but that's another story.

-- TWiki:Main/MartinKaufmann - 24 Jan 2008

I got the same bug on another 4.1.2 installation without NatEditContrib installed. After inserting a link, the buttons (which are below the text area) don't work either and vbls is not defined is shown.

-- TWiki:Main.MartinKaufmann - 25 Jan 2008

In 4.2 the buttons are not deactivated. But the link feature seems broken. I was testing this beyond madness in relation to Item4535 and now nothing seems to work again. I cannot add links anymore unless it is a real URL. It is totally broken.

If I already have a square bracket link and I put the mouse on it and click the link icon some javascript is triggered asking if I really want to navigate away.

When I add a link with the icon using a WikiWord and not a http type link then at first sight things look OK. But when you save no link is added. And I see that IE reports Javascript error when I save.

Linking is basically totally broken in 4.2.0. You cannot link with Wysiwyg. It seems none of us tested linking in Wysiwyg the days or weeks before the release. This is a really nasty error.

I am testing in IE6 as I write this.

-- TWiki:Main.KennethLavrsen - 25 Jan 2008

Bugger, you are absolutely right; the JS error effectively blcoks further useful behaviour.

Working on a fix.

CC

I don't know how that happened; it looks like two opposite sides of a merge survived.

Fixed now, will upload fixed TinyMCEPlugin shortly. Users should be able to upgrade from Plugins web without issues. Set for feedback for Kenneth so he can decide what action is appropriate w.r.t the release.

CC

We shall not panic a new release out. We knew 4.2.0 RCs was only tested by a very small number of live sites and that bugs would occur.

What we do is

• Add to Known Issues
• Generic note that installers of 4.2.0 should update the plugins via configure regularly with special emplasis on the Wysiwyg/Tiny pair because it is a new feature. It is so easy to do thanks to configure.

I will take these doc actions.

-- TWiki:Main.KennethLavrsen - 25 Jan 2008

I checked the fix and I see no fix.

If I add a some text, select a word, add a link using the link icon and I write a WikiWord as the link text and save everything I typed is lost. It is like I had not saved the topic.

I checked both in FF and IE. How did this fix pass your own testing? Do you have some files that are not in sync on the SVN repository.

How did you test this yourself? Did you just add the link and did not save it but just saw the text got blue?

-- TWiki:Main.KennethLavrsen - 25 Jan 2008

Ah. Fixes were not merged to the TWikiRelease04x02 branch.

I sent an instruction on the mailing list that I prefer that developers merge over fixes and test them in the T42 branch. The risk I miss something is too large.

I have tested it and yes, it works now.

-- TWiki:Main.KennethLavrsen - 25 Jan 2008

I wanted to test that I could update by Motion site via configure so I decided to give a hand and do the release to twiki.org.

So you have no open actions on this Crawford. On to the next bug

With thanks KJL

-- TWiki:Main.KennethLavrsen - 25 Jan 2008

TWiki:Codev.KnownIssuesOfTWiki04x02 says, "You can upgrade WysiwygPlugin and TinyMCEPlugin and this problem is fully resolved". But every time I try to edit an existing topic with the default editor, I get an error, "There was a problem retrieving the page: Bad Request". And since the default editor is used every time a new topic is created, I can't create topics unless I disable those plug-ins.

Here's what my stack look like:

• Internet Explorer 6.0 SP2
• TinyMCEPlugin 16290 (25 Jan 2008)
• WysiwygPlugin 16350 (06 Feb 2008)
• TWiki-4.2.0, Tue, 22 Jan 2008, build 16278, Plugin API version 1.2
• Perl version 5.8.8 (cygwin)
• Cygwin 1.5.24(0.15642) (cygwin-thread-multi-64int)
• Apache/1.3.39 (Win32)
• Windows 2003 Server SP1

-- TWiki:Main.SeanCMorgan - 14 Feb 2008