• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item5280: Topic Titles Published with Raw Heading Markup

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Extension PublishContrib Normal No Action Required TWiki:Main.JohnDeStefano n/a  

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

-- TWiki:Main/JohnDeStefano - 22 Jan 2008

All of our TWiki 4.1.2 topic titles are being published to HTML via PublishContrib version 15973 (11 Dec 2007) with raw ---+!! strings in front and in plain text, instead of being displayed as previous in normal "h1" style.

Example title code, from the TWiki.PublishContrib topic:

TWiki title code:

---+!! <nop>%TOPIC%

Published HTML title: ---+!! PublishContrib

It seems that Publish worked properly when the TWiki topic included a line break between the opening of the content div and the h1 heading text. When this line did not exist, and when the heading was included on the same line as the content div opening tags (along with other tags, such as the breadcrumbs, revision, etc.), Publish failed to recognize the header text as such and published it to HTML as a raw string.

A colleague of mine, Jason Smith, discovered a fix by inserting a new line character into Publish.pm in front of the $text variable, at the point where %TEXT% is replaced with $text (at line 559). See attached diff file.

-- TWiki:Main.JohnDeStefano - 04 Feb 2008

John, what template are you using? Because it sounds like there should be a newline in the template before %TEXT%. A code fix should not be necessary.

-- CrawfordCurrie - 20 Aug 2008

No response from reporter, and the problem can't be reproduced, so closing.

-- CrawfordCurrie - 27 Oct 2008

I reported this issue in Jan 2008, and followed up in Feb 2008 with what I thought would be a helpful response, and gave up on it a few months later. I had no idea a question had been asked of me in Aug 2008. If it's possible to subscribe to 'develop' changes somehow and be notified via email, please let me know how.

We are using a template based on the Pattern skin.

-- TWiki:Main.JohnDeStefano - 22 Jan 2009

ItemTemplate
Summary Topic Titles Published with Raw Heading Markup
ReportedBy TWiki:Main.JohnDeStefano
Codebase 4.1.2
SVN Range TWiki-4.3.0, Tue, 15 Jan 2008, build 16238
AppliesTo Extension
Component PublishContrib
Priority Normal
CurrentState No Action Required
WaitingFor TWiki:Main.JohnDeStefano
Checkins

TargetRelease n/a
ReleasedIn

Topic attachments
I Attachment History Action Size Date Who Comment
Unknown file formatdiff Publish.pm.diff r1 manage 0.1 K 2008-02-04 - 16:06 JohnDeStefano diff of changes to Publish.pm
Edit | Attach | Watch | Print version | History: r5 < r4 < r3 < r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r5 - 2009-01-22 - JohnDeStefano
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback