• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item5185: User mapping testcase is giving a false positive

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine   Urgent Closed   minor 4.2.0

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

In FuncUsersTests there are two functions that enable/disable the AllowLoginName

However they are setting $TWiki::cfg{AllowLoginName} instead of $TWiki::cfg{Register}{AllowLoginName}, so have no effect.

If the correct switch is used, the tests fail.

-- TWiki:Main/CrawfordCurrie - 31 Dec 2007

bugger. I'll look at it when i have 'net, and see if it can / needs to be dealt with for the release.

-- TWiki:Main.SvenDowideit - 02 Jan 2008

All the failures appear to be in the $TWiki::cfg{Register}{AllowLoginName} = 0; case, and Why, appears to be somewhat clear when you look at the set_up_for_verify function - it was written to assume AllowLoginName = 1.

This 'problem' was caused because the FuncUser tests were not updated to work correctly for AllowLoginName = 0; I remember looking into fixing the tests a while back, but it slipped my mind frown

I have fixed the unit tests, and simplified the UserMapping code to resolve some issues, but we're going to have to spend some time re-testing group membership under the many different options.

-- TWiki:Main.SvenDowideit - 07 Jan 2008

Thanks Sven. I'm simplifying the tests (among other things) at the moment, as I go through implementing the TOM. Of course that only impacts MAIN frown

CC

I have not seen any negative effects since these check-ins. Removed my name from feedback field.

KJL

I have no idea what feedback I could give? I did not spot the error, have not contributed to the code nor to the unit tests, am never using $TWiki::cfg{Register}{AllowLoginName} = 0; nor TWiki::Func.

I can't comment on the comment in the source code either:

#login invalid... (TODO: what does that really mean)
"0" doesn't seem to count as a valid password, which I wouldn't mind.

So I'll just close the item....

-- TWiki:Main.HaraldJoerg - 11 Jan 2008

heheh smile I was hoping you might have time to update your installation to make sure that your use case is still ok smile

-- SvenDowideit - 11 Jan 2008

ItemTemplate
Summary User mapping testcase is giving a false positive
ReportedBy TWiki:Main.CrawfordCurrie
Codebase 4.2.0, ~twiki4
SVN Range TWiki-4.3.0, Sun, 30 Dec 2007, build 16120
AppliesTo Engine
Component

Priority Urgent
CurrentState Closed
WaitingFor

Checkins TWikirev:16122 TWikirev:16123 TWikirev:16163
TargetRelease minor
ReleasedIn 4.2.0
Edit | Attach | Watch | Print version | History: r15 < r14 < r13 < r12 < r11 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r15 - 2008-01-22 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback