• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item5108: Get rid of indirection in plugin handler calls

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine Performance Enhancement Closed   patch  

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

Because of an incomplete refactoring, all calls to plugin handlers indirect via the plugins object. This makes sense in a statically comiled language, but in an interpreted language like perl it is dumb. For example,
$twiki->{plugins}->commonTagsHandler(...)

is implemented as

sub commonTagsHandler { 
   my $this = shift ;
    $this->_dispatch('commonTagsHandler', @_);
}

All the handlers are implemented the same way. This slows down the code in two ways; because of the indirection, but also because of all the extra code that has to be compiled. It also makes adding a new handler a painful process.

Get rid of the indirection and call the dispatcher direct. It also makes the code clearer.

-- TWiki:Main/CrawfordCurrie - 10 Dec 2007

Done in MAIN; mark as "waiting for release" when 4.2.0 is gone.

CC

Cleaned "WaitingFor" field.

-- TWiki:Main.GilmarSantosJr - 10 Aug 2008

ItemTemplate
Summary Get rid of indirection in plugin handler calls
ReportedBy TWiki:Main.CrawfordCurrie
Codebase

SVN Range TWiki-4.3.0, Sun, 25 Nov 2007, build 15790
AppliesTo Engine
Component Performance
Priority Enhancement
CurrentState Closed
WaitingFor

Checkins TWikirev:16003 TWikirev:16034
TargetRelease patch
ReleasedIn

Edit | Attach | Watch | Print version | History: r7 < r6 < r5 < r4 < r3 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r7 - 2008-08-10 - GilmarSantosJr
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback