• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item5104: HistoryPlugin has lost all its RevComment and CompareRevisions features and is no longer working in 4.1

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Extension HistoryPlugin Normal Closed   n/a  

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

I noticed that the fix to make the HistoryPlugin working in 4.2.0 also included an elimination of the oppshistory.pattern.tmpl.

In this process it was missed that this template contained the features that made it work extremely well with its brother plugins CompareRevisionsAddOn and RevCommentPlugin.

With RevCommentPlugin the ooshistory page shows the commented for each revision. You can actually say that without this feature user added comments are a secret.

With CompareRevisionsAddOn you are supposed to be able to choose how you want the changes rendered. Interweaved vs side-by-side.

These two features for sure have to brought back to the default oopshistory.tmpl

It seems the developer that last updated the plugins had not noticed the interaction with the two other plugins - probably because it was only implemented in the pattern version of the template.

While testing I also noticed that the plugin now looks awful and basically does not work in TWiki 4.1.2. The reason is that the 1.1 version of the HistoryPlugin uses a new feature in 4.2 that allows embedding CSS in the header. But this is not available in 4.1.X

I decided make another redesign with simpler CSS all embedded in the html. Maybe more primitive but IT WORKS in 4.1.X and it is sad if we have to have multiple versions of the same plugin because of an incompatible implementation of very few styles.

As I did the redesign I also found that the new layout was a bit over-engineered and a bit difficult to make look good also in 4.1.2. So I took the best of the old version of the plugins and combined with the best of the new design. The result is something third but pretty nice.

I have tested this for about 12 hours. I tested with all combinations of the 3 plugins. I tested all these combinations with all combinations of IE6, IE7 and FF2. And again all those in TWiki 4.1.2 and 4.2.0.

All in all I think I have gotten HistoryPlugin in a pretty good shape. It took two full days this weekend. Documentation is also updated so I will release a new version to t.o.

-- TWiki:Main/KennethLavrsen - 09 Dec 2007

Michael Daum had also made a rev 1.2 but I had missed that because he had not merged it to the T42 branch (which in principle is OK - that is actually not required). My fault.

Good thing that he had worked on the plugin code and I on the templates so the merge is simple. Uploading a 1.3.

-- TWiki:Main/KennethLavrsen - 10 Dec 2007

ItemTemplate
Summary HistoryPlugin has lost all its RevComment and CompareRevisions features and is no longer working in 4.1
ReportedBy TWiki:Main.KennethLavrsen
Codebase 4.2.0, ~twiki4
SVN Range TWiki-4.3.0, Sun, 25 Nov 2007, build 15790
AppliesTo Extension
Component HistoryPlugin
Priority Normal
CurrentState Closed
WaitingFor

Checkins TWikirev:15948 TWikirev:15949 TWikirev:15950 TWikirev:15951 TWikirev:15952 TWikirev:15953
TargetRelease n/a
ReleasedIn

Edit | Attach | Watch | Print version | History: r10 < r9 < r8 < r7 < r6 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r10 - 2007-12-10 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback