• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item4748: Interwiki link pattern breaks SEARCH summary, again

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine   Normal Closed   minor 4.2.0

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

Interwiki link test case: START Wikipedia:TWiki END

SEARCH summary of this topic: Interwiki link test case: START Wikipedia:TWiki END SEARCH summary of this topic: Bug description: A SEARCH summary shows Interwiki links linked. They should...

Bug description: A SEARCH summary shows Interwiki links linked. They should be plain text, or TWiki apps and RSS feeds that depend on a plain text summary break. This has been reported & fixed several times ( Item2691, Item744, possible more.)

Low hanging fruit fix: In summary handling, prefix ":" with a nop tag.

-- TWiki:Main/PeterThoeny - 30 Sep 2007

Probbaly several plugins catches and renders search output, FindElsewherePlugin to mention another. Better to have InterwikiPlugin respect <noautolink> (if it doesn't already). - Alternatively output a <noautolink> with search output.

-- TWiki:Main.SteffenPoulsen - 30 Sep 2007

sounds like someone that knows lots about interwiki needs to write a good set of unit tests.

-- TWiki:Main.SvenDowideit - 06 Oct 2007

On review, while Peter has reported this several times, no-one has yet come up with a fix. On the basis that it has been broken consistently since 3rd Dec 2005, and no-one but Peter has even noticed, inclines me to think this is not urgent, not a release blocker for 4.2.

Confirmed and downgraded to Normal.

-- CrawfordCurrie - 20 Oct 2007

This will break RSS feeds and TWiki apps that depend on a plain text summary. Restoring to urgent.

-- TWiki:Main.PeterThoeny - 12 Dec 2007

Above search output repeated with noautolink:

SEARCH summary of this topic: Interwiki link test case: START Wikipedia:TWiki END SEARCH summary of this topic: Bug description: A SEARCH summary shows Interwiki links linked. They should...

In some case you want the search output to be linked up, re-assigning this item to InterwikiPlugin.

But search does output <, >, &, " and similar which it would be meaningful to eliminate for RSS outputs (reported elsewhere).

-- TWiki:Main.SteffenPoulsen - 12 Dec 2007

To iterate on existing related items:

Would be good to finally have some of these closed.

-- TWiki:Main.SteffenPoulsen - 12 Dec 2007

I have committed a fix for the interwiki behaviour, but I would be glad if you Peter would clean up this and earlier items (especially duplicates) - possibly leaving just one open with the iterated remainder of the problem(s).

-- TWiki:Main.SteffenPoulsen - 12 Dec 2007

how is it that people claim to have fixes issues like this, and have not added any unit tests for them?

-- TWiki:Main.SvenDowideit - 13 Dec 2007

Good point. I am unsure to what the spec is for the fix needed here, so I only did the noautolink part.

If we agree on a spec I can do some unit tests.

-- TWiki:Main.SteffenPoulsen - 13 Dec 2007

No, the noautolink trick is not a proper fix. WebChanges and other reports use $summary. They expect plain text; we can't change the spec to require enclosing all searches in noautolink tags.

Low hanging fruit fix: In core code's summary handling, prefix ":" with a nop tag. This nop escapes interwiki links; it gets removed at the end of the rendering stage.

-- TWiki:Main.PeterThoeny - 15 Dec 2007

To iterate: The $summary output is pure plain text already, it is the plugin that massages the output afterwards.

If there's a wikiword in the $summary output and you have findelsewhereplugin enabled, that will also trigger a rendering (and so on) - I think it is a bad strategy to implement plugin-specific rendering-stopping mechanisms in SEARCH output.

If anything, it should output a (optional/default?) <noautolink> before and after its $summary output (as already suggested earlier). That would be a "plugin-generic" strategy for the $summary output.

Any thoughts on the earlier items on this subject?

-- TWiki:Main.SteffenPoulsen - 16 Dec 2007

I see the noautolink trick as a workaround for the actual issue that plain text is not plain text anymore due to a plugin interference. The core should protect against these kind of issues.

-- TWiki:Main.PeterThoeny - 17 Dec 2007

My basic problem is that I am not sure there is such a thing as a universal "plain text" format. What is plain text to one plugin is yummy-yummy renderable content to another (findelsewhere already mentioned as an example).

I would be happy to see other opinions.

BTW: To me noautolink is not a trick, it is simply just the right way to lock down content against unwanted rendering. For instance TWiki.TWikiEditingShorthand says: "It is possible to turn off all auto-linking with a NOAUTOLINK preferences setting".

-- TWiki:Main.SteffenPoulsen - 17 Dec 2007

For 4.2.0 we go for the safe and easy solution. Then we save a whale next time wink

Unit tested Peter's fix and checked it in.

-- TWiki:Main.KennethLavrsen - 18 Dec 2007

Let's keep it open for the whales, then. When this item is finally closed most of the related items should be closed also (se above).

Checking in a fix for the NOAUTOLINK preferences setting, which wasn't being respected either.

  • DISABLE Set NOAUTOLINK = on
    • I disabled above setting since it renders the test case on top inoperable. - PTh

-- SteffenPoulsen - 18 Dec 2007

I disagree with Steffen on plain text: Plain text is just text, it should not contain any links or images. This item is specifically for plain text format of the summary, regardless of other system settings and text manipulation of plugins. We had to fix a similar bug in the past where expanded smilies corrupted RSS feeds. Plain text needs to be plain text.

Let's close this bug item. Please do not use this bug item for NOAUTOLINK fix and other fixes, open a new bug item if needed.

-- TWiki:Main.PeterThoeny - 18 Dec 2007

I think it is a good point that plain text needs to be plain text - I think it is just the definition of plain text that we disagree on smile

The smilies case is a good one - had we back then escaped the search output with noautolink this issue would have never turned up. Now we can just wait for the next plugin to kick in on a new special char combination ...

-- TWiki:Main.SteffenPoulsen - 18 Dec 2007

First - this bug was about search summaries and Interwiki Plugin.

Second. I do not agree that NOAUTOLINK should also influence plugins. This is not specified. This is a new invention and it will break things. We are close to a release Steffen. Reverting

-- TWiki:Main.KennethLavrsen - 18 Dec 2007

ItemTemplate
Summary Interwiki link pattern breaks SEARCH summary, again
ReportedBy TWiki:Main.PeterThoeny
Codebase ~twiki4
SVN Range TWiki-4.3.0, Sat, 22 Sep 2007, build 14996
AppliesTo Engine
Component

Priority Normal
CurrentState Closed
WaitingFor

Checkins TWikirev:15977 TWikirev:15978 TWikirev:16025 TWikirev:16026 TWikirev:16027 TWikirev:16028 TWikirev:16052 TWikirev:16053
TargetRelease minor
ReleasedIn 4.2.0
Edit | Attach | Watch | Print version | History: r25 < r24 < r23 < r22 < r21 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r25 - 2007-12-18 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback