• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item4616: Edit using TMCE deleted whole of topic text

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Extension TinyMCEPlugin Urgent Closed   n/a  

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

TinyMCEPlugin deleted the whole of Item4583 when I was trying to save a revision. Steps were:

1. Starting with rev 5, I made a change using Comment plugin (would be rev 6 but was not saved in RCS somehow)

2. later on, edited my comment using TMCE, which appeared to work (no I18N characters in either change but there are in the topic as it's reporting I18N bug in TMCE)

3. Hit Save

4. Got this server side error (including '=' no either end, which is weird).

=Wide character in print at /home/twiki4/twikisvn/lib/TWiki/Store/RcsFile.pm line 797. at /home/twiki4/twikisvn/lib/TWiki/UI.pm line 84 TWiki::UI::__ANON__('Wide character in print at /home/twiki4/twikisvn/lib/TWiki/St...') called at /home/twiki4/twikisvn/lib/TWiki/Store/RcsFile.pm line 797 TWiki::Store::RcsFile::saveFile('TWiki::Store::RcsWrap=HASH(0x99e18bc)', '/home/twiki4/twikisvn/data/Bugs/Item4583.txt', '%META:TOPICINFO{author="RichardDonkin" date="1189636018" form...') called at /home/twiki4/twikisvn/lib/TWiki/Store/RcsWrap.pm line 155 TWiki::Store::RcsWrap::replaceRevision('TWiki::Store::RcsWrap=HASH(0x99e18bc)', '%META:TOPICINFO{author="RichardDonkin" date="1189636018" form...', 'undef', 'RichardDonkin', 1189636018) called at /home/twiki4/twikisvn/lib/TWiki/Store.pm line 1128 TWiki::Store::__ANON__() called at /home/twiki4/twikisvn/lib/CPAN/lib//Error.pm line 379 eval {...} called at /home/twiki4/twikisvn/lib/CPAN/lib//Error.pm line 371 Error::subs::try('CODE(0x999f100)', 'HASH(0x99e1760)') called at /home/twiki4/twikisvn/lib/TWiki/Store.pm line 1132 TWiki::Store::repRev('TWiki::Store=HASH(0x9245f90)', 'RichardDonkin', 'Bugs', 'Item4583', 'I have just found out that TinyMCEPlugin has started working ...', 'TWiki::Meta=HASH(0x99a1cb4)', 'HASH(0x970a13c)') called at /home/twiki4/twikisvn/lib/TWiki/Store.pm line 1042 TWiki::Store::_noHandlersSave('TWiki::Store=HASH(0x9245f90)', 'RichardDonkin', 'Bugs', 'Item4583', 'I have just found out that TinyMCEPlugin has started working ...', 'TWiki::Meta=HASH(0x99a1cb4)', 'HASH(0x970a13c)') called at /home/twiki4/twikisvn/lib/TWiki/Store.pm line 863 TWiki::Store::__ANON__() called at /home/twiki4/twikisvn/lib/CPAN/lib//Error.pm line 379 eval {...} called at /home/twiki4/twikisvn/lib/CPAN/lib//Error.pm line 371 Error::subs::try('CODE(0x97cb594)', 'HASH(0x99a9f68)') called at /home/twiki4/twikisvn/lib/TWiki/Store.pm line 866 TWiki::Store::saveTopic('TWiki::Store=HASH(0x9245f90)', 'RichardDonkin', 'Bugs', 'Item4583', 'I have just found out that TinyMCEPlugin has started working ...', 'TWiki::Meta=HASH(0x971d514)', 'HASH(0x970a13c)') called at /home/twiki4/twikisvn/lib/TWiki/UI/Save.pm line 523 TWiki::UI::Save::__ANON__() called at /home/twiki4/twikisvn/lib/CPAN/lib//Error.pm line 379 eval {...} called at /home/twiki4/twikisvn/lib/CPAN/lib//Error.pm line 371 Error::subs::try('CODE(0x96edc20)', 'HASH(0x999ef98)') called at /home/twiki4/twikisvn/lib/TWiki/UI/Save.pm line 532 TWiki::UI::Save::save('TWiki=HASH(0x8e69b3c)') called at /home/twiki4/twikisvn/lib/TWiki/UI.pm line 159 TWiki::UI::__ANON__() called at /home/twiki4/twikisvn/lib/CPAN/lib//Error.pm line 379 eval {...} called at /home/twiki4/twikisvn/lib/CPAN/lib//Error.pm line 371 Error::subs::try('CODE(0x8e69de8)', 'HASH(0x9709fb0)') called at /home/twiki4/twikisvn/lib/TWiki/UI.pm line 197 TWiki::UI::run('CODE(0x91d2eac)', 'save', 1) called =

comments on bug

This indicates somehow that TMCE and/or the server side code is doing both of the following:

  1. Passing UTF-8 encoded bytes to RcsFile.pm - this is completely wrong as (a) this TWiki site should be using ISO-8859-1 exclusively and (b) we don't yet support UTF-8 (see TWiki:Codev.UnicodeSupport and TWiki:TWiki.InstallationWithI18N - only Japanese/Chinese sites should use UTF-8, since it breaks WikiWord recognition of I18N chars
  2. Even worse, these bytes are being turned into Perl internal Unicode characters (also UTF-8 encoded, but each character is a single unit and specially handled by Perl 5.8 upwards) - this is a complete no-no and is why we get the wide char error above.

Any use of UTF-8 outside TWiki:Codev.EncodeURLsWithUTF8 is a bug until we get full UnicodeSupport done, which is quite a lot of work and has a significant performance impact (at least it did last time I tried it).

TMCE I18N suggestion

To make progress with TMCE, I suggest the following simple strategy for now:

  1. Only use ISO-8859-1 (and check that develop configure is not use a site charset of -15 under covers, as that breaks things too)
  2. Only test non-I18N cases for now
  3. Exclude any I18N characters (8-bit-high characters) and URL-encoded URLs from use (but document as TODOs)

There are enough bugs in TMCE without worrying about I18N right now.

Copy/paste digression

Note: TMCE copy/paste not working for some reason, continuing with raw edit. for this report

  • We need to disable TMCE for new bug reports - it's very slow on my 700 MHz Linux box, and more importantly things don't work well enough yet.
  • I have already got the relevant 'disable TMCE' incantation in the RichardDonkin page here, is there a typo in it? I doesn't seem to affect anything

TMCE copy/paste issue (separate bug really): I have not changed the client (Linux) copy/paste buffer since switching to raw edit, but:

  • Within TMCE, paste only seems to work on text cut from earlier TMCE buffer - yet since doing that cut I had done a Copy within gvim (of the error message I'm reporting here)
  • Once in Raw Edit, paste works OK, so I don't think it's a browser (Opera 9.23 on Ubuntu Linux 5.10) bug
  • Pasting into another KDE tool (kate editor) also pastes the latest system copy/paste buffer contents
  • TMCE is the only part of this that doesn't seem to use the global system copy/paste

TMCE then raw edit issue digression

On creating this bug report (4616) I used TMCE, then saved and did raw edit. Despite now being in raw edit, the topic was entirely HTML not TML - lots of Paragraph markup. This is another TMCE bug.

TMCE use for bug reporting

Sorry for the digressions, but encountering 2 separate TMCE bugs while reporting this TMCE bug, which came about when trying to save bug report also related to TMCE, is quite distracting - I think this illustrates we should not use TMCE for bug reporting by default, i.e. Create New Report should not use it. The Raw Edit option is great for editing existing pages.

-- TWiki:Main/RichardDonkin - 13 Sep 2007

No, we absolutely should use it. This is our testbed; it's the only way we have of being sure that stuff gets exercised. We put up with the trip-ups precisely because we need to find the things that trip people up!

No problem with the conversion now. You hit 4617, I suspect.

Please don't pack new problems into existing reports; I find it hard enough to keep track as it is. I'd be grateful if you could create a new report for each problem, together with details of how to reproduce the problem.

Closing this, as as the original problem that was reported has been fixed Item4617.

CC

OK, then let's provide a Create New Report option that uses the raw editor, or enable my homepage setting to get this to work. I don't think struggling with Create New Report in TMCE is reasonable when it has this many bugs at present.

I will submit these as separate bugs when I get time. Having 3 problems listed here was partly to show why we need to make it possible to disable TMCE, even when creating new reports. Agree that it's confusing, but remember my original purpose was to report one new bug.

-- TWiki:Main.RichardDonkin - 14 Sep 2007

ItemTemplate
Summary Edit using TMCE deleted whole of topic text
ReportedBy TWiki:Main.RichardDonkin
Codebase ~twiki4
SVN Range TWiki-4.2.0, Sat, 08 Sep 2007, build 14780
AppliesTo Extension
Component TinyMCEPlugin
Priority Urgent
CurrentState Closed
WaitingFor

Checkins TWikirev:14848
TargetRelease n/a
ReleasedIn

Edit | Attach | Watch | Print version | History: r7 < r6 < r5 < r4 < r3 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r7 - 2007-09-14 - RichardDonkin
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback