• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item4510: Remove inline scripts

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine   Normal Closed   minor 4.2.0

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

An oversight: if inline scripts are disabled some topics will give an error.

-- TWiki:Main/ArthurClemens - 27 Aug 2007

Note that this one is concerning if things work when {AllowInlineScript} is disabled in Configure (security tab).

The problem is that you get some error messages.

This bug item does not cover graceful fallback. If someone sees a script that does not fallback gracefully please raise a bug item on it.

Arthur volunteered to look at this so assigning to him. When fixed this goes to "Waitng for release" because it is also in 4.1.2

-- TWiki:Main.KennethLavrsen - 28 Aug 2007

I have replaced the red error message by an HTML comment. I have removed the inline script from pattern's WebTopicBar.

3 topics still have javascript:

  • WebSearch
  • WebSearchAdvanced
  • TWikiRegistration
Those topics function as well without javascript. And without a red message the topics can be used without looking broken. -- TWiki.Main.ArthurClemens - 30 Aug 2007

I have removed the scripts from WebSearch and WebSearchAdvanced as well now. The script has been moved to pattern.js.

-- TWiki:Main.ArthurClemens - 02 Oct 2007

More work to do.

-- TWiki:Main.ArthurClemens - 05 Oct 2007

I eliminated all except one (oopslanguagechanged) from the default templates. I'm not confident to remove this last one.

That template is under scrutiny for possible removal. As it is not such a big problem if that script gets eaten, lowering this from Urgent to Normal, and marking for Arthur's attention.

CC

I have removed the script from that template. It still works.

-- TWiki:Main.ArthurClemens - 17 Dec 2007

Edit | Attach | Watch | Print version | History: r25 < r24 < r23 < r22 < r21 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r25 - 2008-01-22 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback