• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item4486: WYSIWYG plugin corrupts heading escapes using double exclamation marks.

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine WysiwygPlugin Normal Closed   minor  

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

Escaping headings from a TOC results in corruption when edited with the WysiwygPlugin. We often use the 'pling pling' syntax to stop headings from appearing in a TOC. Wysiwyg seems to corrupt this.

Before WYSIWYG editing:

---+!!%TOPIC%

After WYSIWYG editing:

---+ !%<nop>TOPIC%   
You can see a space is added, and the second exclamation mark is replaced with a <nop> tag. This makes the topic look really ugly.

-- TWiki:Main/SteveJonesST - 22 Aug 2007

OK, let's try it:

Flibble

Hmmm. Looks OK to me. Can you reproduce in an example LitterTray web? I suspect you are testing using an old version of WysiwygPlugin.... CC Reproduced at TestTopic8, and also on my own installation with the latest WysiwygPlugin. Let me know if you need more, Steve.

-- TWiki:Main.SteveJonesST - 04 Sep 2007

Some more info - this syntax is OK:

---+!! %TOPIC%
But this is not:
---+!!%TOPIC%
So, the lack of space between the exclamation marks and the % causes incorrect translation to TML, even though it is valid syntax. Hope this is helpful. -- TWiki:Main.SteveJonesST - 04 Sep 2007

OK, So here's a heading with a double exclam:

This is a heading

Save Edit again and it appears correctly Save again Still works. Can you reproduce this problem in LitterTray Web please? AFAICT it works fine.

CC

Hi Crawford. Can you try editing TestTopic9. It broke when I edited it, and I've put it back to it's pre-broken state. I think the point is that the heading is a variable, has no space before, and is double exclam escaped. Thanks for your patience.

An aside - I saw your message that TinyMCE should be OK on 4.0.5. I would prefer to use this, but I need to map it to the WYSIWYG button, not the standard edit button. Can I do this easily ?

-- TWiki:Main.SteveJonesST - 04 Sep 2007

OIC, sorry, I misunderstood your report. An example always helps a lot.

To map to the WYSIWYG button, modify the view template to invoke edit...?nowysiwyg=1 for the "normal" edit, and move the old edit link to the WYSIWYG button.

-- TWiki:Main.CrawfordCurrie - 04 Sep 2007

This is due to the order in whcih !% is interpreted. I had to bring it earlier in the rendering cycle for other reasons, and didn't realise at the time that ---+!!% would get caught by it (it's one of those vague, undefined things in TML)

Anyway, I made it consistent with the rendering.

CC

ItemTemplate
Summary WYSIWYG plugin corrupts heading escapes using double exclamation marks.
ReportedBy TWiki:Main.SteveJonesST
Codebase 4.0.5
SVN Range TWiki-4.2.0, Wed, 22 Aug 2007, build 14581
AppliesTo Engine
Component WysiwygPlugin
Priority Normal
CurrentState Closed
WaitingFor

Checkins TWikirev:14776
TargetRelease minor
ReleasedIn

Edit | Attach | Watch | Print version | History: r11 < r10 < r9 < r8 < r7 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r11 - 2007-09-07 - CrawfordCurrie
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback