• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item4439: %INCLUDE breaks enumeration/tables when included topic has file attachments

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine   Urgent Closed   minor 4.2.0

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

If a topic has an attached file, including the topic via %INCLUDE will break enumeration or table formatting. The resulting output will restart enumeration on the next entry or break the table. If enumeration or tabling is not used, an additional space will be included in the listing.

Example of output effect on 4.1.2: http://netscale.cse.nd.edu/twiki/bin/view/Main/PubsStriegel

Note the listings in the Journal subsection that have PDFs directly attached incur an extra spacing (rogue br?) while the one employing the PDF icon that links to an external site (no attachment directly on the topic) enumerates just fine. Entries included inside a table will break the table and display the pipe (|) on both sides if listed as:

| %INCLUDE{"Topic"}% |

will result in:

| TOPIC Text | 

instead of:

TOPIC Text

-- TWiki:Main/AaronStriegel - 07 Aug 2007

An INCLUDE of a topic does not include the attachments; they are only shown when you view the topic directly. I suspect you probably have a vertical bar somewhere in the text of the included topic, but you haven't provided a testcase so it's impossible to verify.

Please provide a testcase. You can use the LitterTray web on this TWiki.

CC

Example is posted at Item4439Test1 that clearly demonstrates the bug identically to the above given link

-- TWiki:Main.AaronStriegel - 10 Aug 2007

Link is broken, direct link listed below:

http://develop.twiki.org/~twiki4/cgi-bin/view/LitterTray/Item4439Test1

-- TWiki:Main.AaronStriegel - 10 Aug 2007

Thanks Aaron. It's probable that the template is including a training \n when an attachment exists, even though there is no attachment table.

CC

This needs to be fixed for 4.2. Raised to Urgent.

CC

Another tough call. The behaviour Aaron describes is indeed the case; though it is fortuitous rather than planned that it works when there is no attachment. if you go back to Cairo, you find that it doesn't work, either.

I'm going to fix it, so that an INCLUDE doesn't import whitespace at the end of topic text, because it seems more useful to me. There is a risk of it breaking an existing TWiki application; however I think this is a low risk. The more testing we do on this, the better!

CC

ItemTemplate
Summary %INCLUDE breaks enumeration/tables when included topic has file attachments
ReportedBy TWiki:Main.AaronStriegel
Codebase 4.1.2
SVN Range TWiki-4.1.2, Tue, 07 Aug 2007, build 14511
AppliesTo Engine
Component

Priority Urgent
CurrentState Closed
WaitingFor

Checkins TWikirev:14780
TargetRelease minor
ReleasedIn 4.2.0
Edit | Attach | Watch | Print version | History: r12 < r11 < r10 < r9 < r8 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r12 - 2008-01-22 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback