• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item4428: RcsLite doesn't convert @'s in authors name and so history doesn't work.

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine RcsLite Normal Closed   n/a  

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

RcsLite doesn't convert @'s in authors name and so history doesn't work.

This helps.

--- RcsLite.pm.oldm10:~/2007-08-01 10:18:27.000000000 +0000Store/RcsLite.pm
+++ RcsLite.pm  2007-08-01 10:18:12.000000000 +0000
@@ -383,9 +383,11 @@
     for( my $i = $this->{head}; $i > 0; $i--) {
         my $d = $this->{revs}[$i]->{date};
         my $rcsDate = TWiki::Store::RcsFile::_epochToRcsDateTime( $d );
+       my $author = $this->{revs}[$i]->{author};
+       $author =~ s/@/@@/g;
         print $file <<HERE;
 1.$i
-date   $rcsDate;       author $this->{revs}[$i]->{author};     state Exp;
+date   $rcsDate;       author $author; state Exp;
 branches;
 HERE
         print $file 'next',$T;

Helps? Do you mean it fixes the problem? If so, does it cure it fully? What other characters are illegal in author names in RCS?

CC

mmm, odd, I thought that the @ was excluded by the {LoginNameFilterIn} setting, and that this was a large part of the raison de' ert.

seems to me like there should be more generic escaping in here, which 4.2.0 does (though We'll need to check that the filtering is in the TWiki::Users code, not in the Mapping, so that mistakes can't be made)

sounds like a unit test is needed to show the problem... etc etc etc

-- TWiki:Main.SvenDowideit - 18 Aug 2007

definatly resolved in 4.2

-- SvenDowideit - 23 Nov 2007

ItemTemplate
Summary RcsLite doesn't convert @'s in authors name and so history doesn't work.
ReportedBy TWiki:Main.HimDel
Codebase 4.1.2
SVN Range TWiki-4.1.2, Wed, 01 Aug 2007, build 14492
AppliesTo Engine
Component RcsLite
Priority Normal
CurrentState Closed
WaitingFor

Checkins

TargetRelease n/a
ReleasedIn

Edit | Attach | Watch | Print version | History: r4 < r3 < r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r4 - 2007-11-23 - SvenDowideit
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback