• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item4417: Loosing TOPICPARENT after edit/save cycle if parent was set to WebHome

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Extension NatSkin Normal Closed   n/a  

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

How to repro:
  • Set the topic parent to WebHome.
  • Save, all is fine.
  • Edit that same topic. The parent shows as "none" on the edit page.
  • Save.
  • Your topic's parent property has been reset to "none" frown

I'm having that bug on our corporate Wiki and my private installation. Both run 4.1.2 with TWiki:Plugins.NatSkin. I'm guessing it's an issue with TWiki engine rather than TWiki:Plugins.NatSkin.

-- TWiki:Main/StephaneLenclud - 26 Jul 2007

I just tried this on both 4.1.2 and MAIN, and it works fine through normal and WYSIWYG edits in Pattern and Classic skins, and with the default templates. Conclusion: problem with Nat skin. Reassinged.

CC

Good to know. Thanks for looking at that.

-- TWiki:Main.StephaneLenclud - 27 Jul 2007

I fixed it by editing edit.nat.tmpl and changing the existing select generating the parent topic selection list box with:

  <select id="parent" name="topicparent">
    <option>none</option>
    %TOPICLIST{"<option value='$name' $marker>$name</option>"
      separator="$n"
      selection="%IFDEFINED{"%URLPARAM{"topicparent"}%" then="%URLPARAM{"topicparent"}%" else="%META{"parent" format="$topic"}%"}%"
    }%
  </select>

The original code is a bit funny (read complicated) and both versions allow the user to make a topic his own parent. Would be nice to have an exclude property in TOPICLIST to fix that.

-- TWiki:Main.StephaneLenclud - 30 Jul 2007

BTW although it fixes that bug the solution proposed above ain't working with the topicparent URL parameter as it is passed as web.topic more over it keeps storing the TOPICPARENT as topic instead of web.topic. See TWiki:Codev.StoreWebInTOPICPARENT.

-- TWiki:Main.StephaneLenclud - 31 Jul 2007

Here is what I came up with as a temporary work around:

%IFDEFINEDTHEN{"%URLPARAM{"topicparent"}%"}%
  <select id="parent" name="topicparent">
    <option>none</option>
    %TOPICLIST{"<option value='$web.$name' $marker>$name</option>"
      separator="$n"
      selection="%BREADCRUMBS{"%URLPARAM{"topicparent"}%"
        recurse="off"
        exclude="%WEBHOME%|%WEB%|%TOPIC%"
        format="$name"
      }%"
    }%
  </select>
%ELSEDEFINED%
  <select id="parent" name="topicparent">
    <option>none</option>
    %TOPICLIST{"<option value='$web.$name' $marker>$name</option>"
      separator="$n"
      selection="%META{"parent" format="$topic" dontrecurse="on"}%"
    }%
  </select>
%FIDEFINED%

Now I believe a proper solution would be to fix TWiki:Plugins.BreadCrumbsPlugin so that it does not exclude WebHome when WebHome is not listed in exclude.

-- TWiki:Main.StephaneLenclud - 31 Jul 2007

Fixed in Item4689 and released as NatSkin-3.0-pre15

-- TWiki:Main.MichaelDaum - 21 Sep 2007

ItemTemplate
Summary Loosing TOPICPARENT after edit/save cycle if parent was set to WebHome
ReportedBy TWiki:Main.StephaneLenclud
Codebase 4.1.2
SVN Range TWiki-4.1.2, Thu, 19 Jul 2007, build 14438
AppliesTo Extension
Component NatSkin
Priority Normal
CurrentState Closed
WaitingFor

Checkins

TargetRelease n/a
ReleasedIn

Edit | Attach | Watch | Print version | History: r7 < r6 < r5 < r4 < r3 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r7 - 2007-09-21 - MichaelDaum
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback