• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item4391: TWiki should not render contents of HTML comments into new code

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine   Normal No Action Required TWiki:Main.VickiBrown n/a  

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

c.f. twiki.org/cgi-bin/view/Support/HTMLCommentTurnedIntoTWikiLink

Our TWiki installation predates STARTSECTION/ENDSECTION in TWiki. (We've since updated). Thus we have many instances of using INCLUDE.. pattern= to work around this lack of INCLUDE functionality.

I discovered something very odd while trying to troubleshoot an inclusion that was failing.

Here's a raw view of the TWiki page:

<!-- BEGIN_INCLUDE -->
   * ops-announce is our primary *outbound* announcement list, used for communication *to* our supported clients 
...
<!-- END_INCLUDE -->

But here's what a View Source of the rendered page shows in the Browser

<!-- <span class="twikiNewLink">BEGIN_INCLUDE<a title="Create this topic" 
href="/edit/MyWeb/BEGIN_INCLUDE?topicparent=MyWeb.EmailManagement" rel="nofollow"><sup>?</sup></a></span> -->
<p /> <ul>
<li> ops-announce is our primary <strong>outbound</strong> announcement list, 
used for communication <strong>to</strong> our supported  clients.
...
<!-- <span class="twikiNewLink">END_INCLUDE<a title="Create this topic" h
ref="/edit/MyWeb/END_INCLUDE?topicparent=MyWeb.EmailManagement" rel="nofollow"><sup>?</sup></a></span> -->

It's one thing for TWiki to peek inside a comment foor things like * Set directives and other TWiki commands. But don't reformat the comment content in the process.

-- TWiki:Main/VickiBrown - 19 Jul 2007

This does not happen in any of my versions. It seems like TWiki is (mis)taking the underscore as a lower-case letter. Did you change any of the TWiki regexes?

TWiki is (almost) totally agnostic with regard to HTML syntax, so an attempt to make it recognize HTML comments would make the parser even more complex than it already is...

-- TWiki:Main.HaraldJoerg - 19 Jul 2007

Please re-open with more information - not reproducible as reported.

-- TWiki:Main.SteffenPoulsen - 17 Sep 2007

ItemTemplate
Summary TWiki should not render contents of HTML comments into new code
ReportedBy TWiki:Main.VickiBrown
Codebase

SVN Range TWiki-4.1.2, Tue, 17 Jul 2007, build 14423
AppliesTo Engine
Component

Priority Normal
CurrentState No Action Required
WaitingFor TWiki:Main.VickiBrown
Checkins

TargetRelease n/a
ReleasedIn

Edit | Attach | Watch | Print version | History: r3 < r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r3 - 2007-09-17 - SteffenPoulsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback