• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item4380: mailnotify fails due to TWIki::Merge failing

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine   Urgent Closed   minor 4.2.0

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

After invoking mailnotify, it fails with the following message:
[Wed Jul 18 13:48:43 2007] mailnotify: Undefined subroutine &Algorithm::Diff::traverse_balanced called at /home/twiki/new/MAIN/lib/TWiki/Merge.pm line 205.

I checked and Algorithm::Diff in in the @INC path.

The following patch fixes the problem, but I don't want to risk integrating it after all the work Crawford did to prevent unwanted compilation (and I'm a noob regarding when to use or require or how the .pm modules are loaded).

Index: lib/TWiki/Merge.pm
===================================================================
--- lib/TWiki/Merge.pm  (revision 14414)
+++ lib/TWiki/Merge.pm  (working copy)
@@ -202,6 +202,7 @@
     my @b = split( /($sep)/, $ib );

     my $out = [];
+    require Algorithm::Diff;
     Algorithm::Diff::traverse_balanced( \@a, \@b,
                                         {
                                          MATCH => \&_sAcceptA,
@@ -310,7 +311,7 @@
     my @a = split( /(.+?$sep)/, $ia );
     my @b = split( /(.+?$sep)/, $ib );
     my @c = split( /(.+?$sep)/, $ic );
-
+    require Algorithm::Diff;
     my @bdiffs = Algorithm::Diff::sdiff( \@a, \@b );
     my @cdiffs = Algorithm::Diff::sdiff( \@a, \@c );

-- TWiki:Main/RafaelAlvarez - 18 Jul 2007

Your patch is exactly right - please go ahead and apply it.

CC

Done

-- TWiki:Main.RafaelAlvarez - 19 Jul 2007

Cleaned "WaitingFor" field.

-- TWiki:Main.GilmarSantosJr - 10 Aug 2008

ItemTemplate
Summary mailnotify fails due to TWIki::Merge failing
ReportedBy TWiki:Main.RafaelAlvarez
Codebase 4.1.2
SVN Range TWiki-4.1.2, Tue, 17 Jul 2007, build 14423
AppliesTo Engine
Component

Priority Urgent
CurrentState Closed
WaitingFor

Checkins TWikirev:14433
TargetRelease minor
ReleasedIn 4.2.0
Edit | Attach | Watch | Print version | History: r8 < r7 < r6 < r5 < r4 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r8 - 2008-08-10 - GilmarSantosJr
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback