Item4320: Action Tracker Plugin Installer untar bug

The installer has a bug in untar(). After calling tar with backticks, it checks the success with

  if ($!) ...

But $! is only set for calls to Perl system calls. It may have a true value at this point for no reason at all. The proper way to check the success of the external system call is:

  if ($?) { ... 

-- TWiki:Main/PeterScott - 29 Jun 2007

Oops, well spotted Peter! This isn't specific to the action tracker, it applies to all packages built using the BuildContrib. Not the first time I have done that; I appear to have $!/$? dyslexia

Priority raised to normal, and confirmed.

CC

Fixed. Future packages built using the BuildContrib will get it right.

CC

This bug just doesn't want to die... it is present in 4.3.1 in lib/TWiki/Configure/UIs/EXTEND.pm on lines 308, 310, 311, 345, and 346 and prevents the installation of, e.g. the ActionTracker via the web interface (even though tools/extender.pl appears to duplicate this code... but gets it right!)