• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item4300: TablePlugin overrides skin css AGAIN

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Extension TablePlugin Urgent Closed   minor  

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

Test:

You type:

%TABLE{tableborder="2"}%
| *header* | *header* | *header* |
| data | data | data | 
| data | data | data | 
| data | data | data | 

You get:

header header header
data data data
data data data
data data data

... and this css in the header:

<!--TABLEPLUGIN_table0--><style type="text/css" media="all">
.twikiTable#table0 {border-width:1px;border-style:solid;}
.twikiTable#table0 td {border-width:0px;}
.twikiTable#table0 th {border-width:0px;}
.twikiTable#table0 td {vertical-align:top;}
.twikiTable#table0 th {vertical-align:top;}
.twikiTable#table0 th {background-color:#6b7f93;}
.twikiTable#table0 th.twikiSortedAscendingCol {background-color:#334455;}
.twikiTable#table0 th.twikiSortedDescendingCol {background-color:#334455;}
.twikiTable#table0 th {color:#ffffff;}
.twikiTable#table0 th a:link {color:#ffffff;}
.twikiTable#table0 th a:visited {color:#ffffff;}
.twikiTable#table0 th a:link font {color:#ffffff;}
.twikiTable#table0 th a:visited font {color:#ffffff;}
.twikiTable#table0 th a:hover {color:#6b7f93;background-color:#ffffff;}
.twikiTable#table0 th a:hover font {color:#6b7f93;background-color:#ffffff;}
.twikiTable#table0 tr.twikiTableRowdataBg0 td {background-color:#eeeeee;}
.twikiTable#table0 tr.twikiTableRowdataBgSorted0 td.twikiSortedCol {background-color:#eeeeee;}
</style>
<!--TABLEPLUGIN_table1--><style type="text/css" media="all">
.twikiTable#table1 {border-width:2px;border-style:solid;}
.twikiTable#table1 td {border-width:0px;}
.twikiTable#table1 th {border-width:0px;}
.twikiTable#table1 td {vertical-align:top;}
.twikiTable#table1 th {vertical-align:top;}
.twikiTable#table1 th {background-color:#6b7f93;}
.twikiTable#table1 th.twikiSortedAscendingCol {background-color:#334455;}
.twikiTable#table1 th.twikiSortedDescendingCol {background-color:#334455;}
.twikiTable#table1 th {color:#ffffff;}
.twikiTable#table1 th a:link {color:#ffffff;}
.twikiTable#table1 th a:visited {color:#ffffff;}
.twikiTable#table1 th a:link font {color:#ffffff;}
.twikiTable#table1 th a:visited font {color:#ffffff;}
.twikiTable#table1 th a:hover {color:#6b7f93;background-color:#ffffff;}
.twikiTable#table1 th a:hover font {color:#6b7f93;background-color:#ffffff;}
.twikiTable#table1 tr.twikiTableRowdataBg0 td {background-color:#ffffff;}
.twikiTable#table1 tr.twikiTableRowdataBg1 td {background-color:#edf4f9;}
.twikiTable#table1 tr.twikiTableRowdataBgSorted0 td.twikiSortedCol {background-color:#f5f5f5;}
.twikiTable#table1 tr.twikiTableRowdataBgSorted1 td.twikiSortedCol {background-color:#dce7ee;}
</style>
<!--TABLEPLUGIN_default-->

So first of all there's only one table to be styled. You'd only need to generate css for one TWikiTable. Second, instead of just generating css for the border-width it generates the full set of all table settings, no matter if they come from the TABLEATTRIBUTES preference variable or the %TABLE tag. This in turn overrides any other css settings that are part of a skin's css, coming earlier in the html header.

A release stopper again frown

-- TWiki:Main/MichaelDaum - 25 Jun 2007

There really are 2 tables on this page. The first one is inserted by the template.

But you are right, the css values that are not set should not be written to the page, something I overlooked. But that will be easy to add.

-- TWiki:Main.ArthurClemens - 25 Jun 2007

That was an easy fix.

-- TWiki:Main.ArthurClemens - 25 Jun 2007

Now I am wondering where the 'sorted' style is coming from:

.twikiTable#table0 tr.twikiTableRowdataBg0 td {background-color:#eeeeee;}
Is this set in the template?

-- TWiki:Main.ArthurClemens - 25 Jun 2007

Much better now. But when I only set the tableborder=2 why do I get

.twikiTable#table0 {border-width:2px;border-style:solid;}
instead of
.twikiTable#table0 {border-width:2px;}

-- TWiki:Main/MichaelDaum - 25 Jun 2007

Yes, that is redundant.

-- TWiki:Main.ArthurClemens - 25 Jun 2007

ItemTemplate
Summary TablePlugin overrides skin css AGAIN
ReportedBy TWiki:Main.MichaelDaum
Codebase

SVN Range TWiki-4.1.2, Thu, 21 Jun 2007, build 14235
AppliesTo Extension
Component TablePlugin
Priority Urgent
CurrentState Closed
WaitingFor

Checkins TWikirev:14275 TWikirev:14276
TargetRelease minor
ReleasedIn

Edit | Attach | Watch | Print version | History: r9 < r8 < r7 < r6 < r5 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r9 - 2008-01-22 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback