• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item4273: Uploading attachments breaks when double quotes used in pathname

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Extension BugsWeb Urgent No Action Required   n/a  

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

Attachment break when double quotes are used in pathname - tested on Firefox and Opera on Linux, you get this crash:
Use of uninitialized value in split at /home/twiki4/twikisvn/lib/TWiki/Sandbox.pm line 193.
 at /usr/lib/perl5/5.8.5/CGI/Carp.pm line 314
	CGI::Carp::realdie('Use of uninitialized value in split at /home/twiki4/twikisvn/...') called at /usr/lib/perl5/5.8.5/CGI/Carp.pm line 385
	CGI::Carp::die('Use of uninitialized value in split at /home/twiki4/twikisvn/...') called at /home/twiki4/twikisvn/lib/TWiki/UI.pm line 85
	TWiki::UI::__ANON__('Use of uninitialized value in split at /home/twiki4/twikisvn/...') called at /home/twiki4/twikisvn/lib/TWiki/Sandbox.pm line 193
	TWiki::Sandbox::sanitizeAttachmentName('') called at /home/twiki4/twikisvn/lib/TWiki/UI/Upload.pm line 191
	TWiki::UI::Upload::upload('TWiki=HASH(0x87ec7d8)') called at /home/twiki4/twikisvn/lib/TWiki/UI.pm line 160
	TWiki::UI::__ANON__() called at /home/twiki4/twikisvn/lib/CPAN/lib//Error.pm line 379
	eval {...} called at /home/twiki4/twikisvn/lib/CPAN/lib//Error.pm line 371
	Error::subs::try('CODE(0x87d5d40)', 'HASH(0x91cdf24)') called at /home/twiki4/twikisvn/lib/TWiki/UI.pm line 198
	TWiki::UI::run('CODE(0x8eafbbc)') called

-- TWiki:Main/RichardDonkin - 19 Jun 2007

  • Works ok for me.....:
    wikiringlogo20x20.png

OK, here's a minimal test case:

  1. echo hi >/tmp/hi.txt
  2. Attach this file, taking care to use double quotes in filename (inserted by Firefox on Linux for some filenames): "/tmp/hi.txt"
  3. Get the crash

UPDATE: Now it's started working for some reason - seems to be intermittent, but I could definitely provoke it by adding double quotes just now... Does this site run with SpeedyCGI or ModPerl perhaps?

-- TWiki:Main.RichardDonkin - 19 Jun 2007

nope.

-- TWiki:Main.SvenDowideit - 19 Jun 2007

I think Richard was using the ~develop URL (which I just re-redirected to here), and this is a NOP. Please reopen it if you are still having problems, Richard.

CC

Thanks for redirecting - now, if you could have a look at Item3652 and comment there, I could close off the I18N updates for 4.2, which is what I was originally trying to do.

-- TWiki:Main.RichardDonkin - 21 Jun 2007

ItemTemplate
Summary Uploading attachments breaks when double quotes used in pathname
ReportedBy TWiki:Main.RichardDonkin
Codebase ~twiki4
SVN Range 14213
AppliesTo Extension
Component BugsWeb
Priority Urgent
CurrentState No Action Required
WaitingFor

Checkins

TargetRelease n/a
ReleasedIn

Topic attachments
I Attachment History Action Size Date Who Comment
Texttxt hi.txt r1 manage 0.1 K 2007-06-19 - 16:12 UnknownUser  
Texttxt hi2.txt r1 manage 0.1 K 2007-06-19 - 16:13 UnknownUser test
Unknown file formatpatch near-complete.patch r1 manage 18.5 K 2007-06-19 - 16:05 UnknownUser test
Unknown file formatpatch updated-Item3714.patch r1 manage 18.5 K 2007-06-19 - 16:10 UnknownUser test
Unknown file formatgz updated-Item3714.patch.gz r1 manage 6.3 K 2007-06-19 - 15:52 UnknownUser test
PNGpng wikiringlogo20x20.png r1 manage 1.3 K 2007-06-19 - 15:55 UnknownUser Works ok for me.....
Edit | Attach | Watch | Print version | History: r8 < r7 < r6 < r5 < r4 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r8 - 2007-06-21 - TWikiUserMapping_RichardDonkin
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback