• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item4250: Pipe symbol (i.e. in SEARCH) breaks Form Definition Table

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine   Normal Closed   minor  

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

See http://twiki.org/cgi-bin/view/Support/UnmatchedBracketInRegexVarSEARCH

-- TWiki:Main/FrankSpangenberg - 15 Jun 2007

Form::_parseFormDefinition splits the line on every pipe symbol and handles tags afterwards (in the value-column). This works well, if the author doesnt want to use the pipe symbol i.e. within a SEARCH tag (as a logical OR).

Proposal: call handleCommonTags() before splitting. - Any ideas why this might be a bad idea?

-- TWiki:Main/OliverKrueger - 15 Jun 2007

Oh boy, what a can of worms.

Proposal: call handleCommonTags() before splitting. - Any ideas why this might be a bad idea?

How about when a variable used in the table expands to a value that includes a '|'? Or a newline?

I don't think that would work. How about better handling of \ as an escape character? At the moment only \\n is handled; why not \| as well (even better, use \ as a general escape in form definitions)

CC

Is there more to do than adding a new escape regex to TWiki.pm? I tried adding a new line replacing $pipe with |, but it doesn't work... it wasn't replaced.

-- TWiki:Main.FrankSpangenberg - 16 Jun 2007

There is no $pipe escape, as you discovered (that was really wishful thinking on your part).

This should be resolved by generalised escapes that prevent \| being interpreted as a table column separator in the form parser. Fix in Form.pm

CC

I added \| as an escape for the pipe symbols in form definitions.

CC

ItemTemplate
Summary Pipe symbol (i.e. in SEARCH) breaks Form Definition Table
ReportedBy TWiki:Main.FrankSpangenberg
Codebase 4.1.2
SVN Range TWiki-4.1.2, Sat, 03 Mar 2007, build 13046
AppliesTo Engine
Component

Priority Normal
CurrentState Closed
WaitingFor

Checkins TWikirev:14310
TargetRelease minor
ReleasedIn

Edit | Attach | Watch | Print version | History: r10 < r9 < r8 < r7 < r6 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r10 - 2008-01-22 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback