• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item3760: With rename topic, topic texts are changed as well

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine   Urgent Closed   minor 4.2.0

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

Arhg! TWiki renames text when a topic is renamed. Someone changed topic CMS to Django, and now all occurrences of the text CMS have been changed to Django!

Hmm, this is probably an sometimes unwanted side effect.

-- TWiki:Main/ArthurClemens - 14 Mar 2007

This may be something that only happens with TLA type acronyms since they are normally autolinked - but if CMS is autolinked isn't it correct to change all the CMS instances even outside square brackets?

Having said that, the rename code is really quite horrible and has quite a few lurking bugs.

-- TWiki:Main.RichardDonkin - 14 Mar 2007

Reopening. We have a topic 'Competences'. When renaming this topic, also topics that had filepaths with the word Competences are offered to change the reference of. Also the header is changed to the new name.

This is quite urgent.

-- ArthurClemens - 15 Mar 2007

It is already stated clearly on topic creation that topic names that are not WikiWords will not be autolinked. So it should come as no surprise if rename does not try to update non-WikiWord links.

Creating a topic named "A" or "Is" and then renaming it (to for instance www.buyv1agrahere.com) is a rather desctructive thing to do to an english-speaking TWiki installation currently.

I would say that spec should be updated to only kick renaming in when "before" topic name is a wikiword or when the topic name is found in [[]]-style markup in other topics.

On a side note GlobalReplacePlugin does an excellent job in explaning "before" and "after" changes up front - and even makes the user select the exact instances that the replace should take place - but I realize that putting something like this inside the topic rename usecase has other disadvantages.

-- TWiki:Main.SteffenPoulsen - 17 Mar 2007

it should come as no surprise if rename does not try to update non-WikiWord links could be misinterpreted to the problem: they should not be updated, but they are!

-- TWiki:Main.ArthurClemens - 17 Mar 2007

Another instance: we have a page called "Planet". On renaming this to "PlanetRedesign", I got a list of pages that had the word "Planet" in them. I unchecked all. Then on topic view all instances in the topic text itself were renamed!

This is so bad I had to remove the rename option from the More options page.

-- TWiki:Main.ArthurClemens - 02 Apr 2007

Fix for this when available should also be applied to Patch branch. It is a serious bug

-- TWiki:Main.KennethLavrsen - 02 Apr 2007

I have been unable to reproduce this. Are you sure you weren't running with an early version of Native Search, which had a problem that would show this effect?

Later: I take that back, i managed to reproduce it

CC

Fixed on MAIN but not merged to patch branch.

CC

ItemTemplate
Summary With rename topic, topic texts are changed as well
ReportedBy TWiki:Main.ArthurClemens
Codebase

SVN Range TWiki-4.1.2, Sat, 03 Mar 2007, build 13043
AppliesTo Engine
Component

Priority Urgent
CurrentState Closed
WaitingFor

Checkins TWikirev:13367
TargetRelease minor
ReleasedIn 4.2.0
Edit | Attach | Watch | Print version | History: r12 < r11 < r10 < r9 < r8 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r12 - 2008-01-22 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback