• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Item3533: Redirect to viewauth broken when using script suffix and apache login

Item Form Data

AppliesTo: Component: Priority: CurrentState: WaitingFor: TargetRelease ReleasedIn
Engine   Urgent Closed   patch 4.1.1

Edit Form Data

Summary:
Reported By:
Codebase:
Applies To:
Component:
Priority:
Current State:
Waiting For:
Target Release:
Released In:
 

Detail

Redirect to viewauth broken when using script suffix and apache login

An error in a regex.

I have already fixed it.

Just opening this for the record.

-- TWiki:Main/KennethLavrsen - 30 Jan 2007

Fixed.

the following ended up being broken in this and Item3483

in ApacheLogin.pm there are 3 different types of environments depending on Apache version and short URL setups.

  • $url .= '/' . $ENV{PATH_INFO} if $ENV{PATH_INFO} was added in all 3 cases but is only needed in two of them. The result was that the web and topic name was appended twice in the most normal case.
  • The query string was sent to the redirect. This was originally OK. But after Thomas Weigert added the feature that maintains the query string across redirects the query string needs to be stripped off since it is added later in the redirect function
  • Typo in a code line was correct in the first code fix and later replaced by a new code line.
  • The redirect did not work with script suffix. A regex was too greedy so that the script name became view.pl and the auth version became view.plauth

In TWiki.pm redirect sub

  • A regex was run without checking if a match was happening. The result was that an unrelated value in $1 ended up as an appended as a query string depending on what had occured earlier in ApacheLogin.

Thanks to Crawford for helping finding the latter. That was a tough one.

Fix has been merged into Patch04x01

-- TWiki:Main.KennethLavrsen - 30 Jan 2007

Cleaned "WaitingFor" field.

-- TWiki:Main.GilmarSantosJr - 10 Aug 2008

ItemTemplate
Summary Redirect to viewauth broken when using script suffix and apache login
ReportedBy TWiki:Main.KennethLavrsen
Codebase 4.1.0, ~twiki4
SVN Range TWiki-4.1.0, Mon, 22 Jan 2007, build 12595
AppliesTo Engine
Component

Priority Urgent
CurrentState Closed
WaitingFor

Checkins 12650 12651
TargetRelease patch
ReleasedIn 4.1.1
Edit | Attach | Watch | Print version | History: r7 < r6 < r5 < r4 < r3 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r7 - 2008-08-10 - GilmarSantosJr
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback