• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

If you view an item with ?skin=classic, say, upon edit you are back to the skin that was selected.

That seems odd.

What are the rules how skins are selected?

E.g., which of these sentences should be true:

  1. When we move to a new screen, any currently applied skin is overridden by the skin selected for the session.
  2. When a user applied a skin manually in the URL parameters, that skin becomes the new skin for the continuation of the session.

Now what about cover?

From the description in TWikiScripts I infer that

  • skin once applied should stick around ("overrides the default skin path")
  • cover only applies to the current script ("specifies a temporary skin path")

Therefore, if I have applied ?skin=classic to a url I am viewing, and I am going into edit mode, the edit should also use the classic skin. This is not currently the case. -- TW


I would like to put a question mark whether I would actually want to have the suggested sticky behavour.

Adding a skin=something to the URL would for me always be something temporary. If I really want my users to see a topic in a different skin then I would set the SKIN variable as a preference setting for the topic.

KJL


I agree. I think on balance there are more cases where sticky url params would cause, rather than solve, problems. So i think sentence 1 is true.

Note that a session variable can be used to override a setting for a session. Perhaps you need to think of an easier way to set/access session variables.

CC


I am ok with this but probably we should enhance the doco... -- TW


While stickyness may not in general be desirable, what about when going from view to edit mode? -- TW
Thomas, you left this in Waiting for Feedback state. I assume you really meant to reword it to reflect exactly what additional doc is required, so I'm flipping this back to New for your further analysis.

CC


No, my question was regarding to whether stickyness is desired when going from view mode to edit mode.... --TW


I can see all sorts of problems with this. You should not assume that a skin will stick through an edit. For example, the WYSIWYG editor uses the skin to invoke the relevant template (e.g. ?cover=kupu).

The skin= and cover= url parameters are really designed as temporary overrides just for the pruposes of a single page view. My gut tells me that making them stick is not a good idea, especially when you already have a way to do that (via session variables).

CC


OK. Stick with current non-sticky behavior, but enhance documentation of TWikiSkins to make this clear. Also added example to explain the difference between skin and cover better and added viewprint to the list of templates for PatternSkin. -- TW

ItemTemplate
Summary skin and cover values not currently preserved when going from view to edit
ReportedBy TWiki:Main.ThomasWeigert
Codebase 4.0.0, 4.0.1, 4.0.2, 4.0.3, 4.0.4, 4.0.5, ~twiki4
SVN Range TWiki-4.1, Thu, 09 Nov 2006, build 11947
AppliesTo Engine
Component

Priority Normal
CurrentState Closed
WaitingFor

Checkins 12442
TargetRelease minor
Edit | Attach | Watch | Print version | History: r13 < r12 < r11 < r10 < r9 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r13 - 2007-01-16 - JasonHill
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback