• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

A newly installed TWiki4.1 installed from a newly built tgz does not show any skin. It runs in classic skin. No pattern.

No errors in apache log to indicate why.

It seems the pseudo-install is not a sufficient test bed anymore for developers.

KJL

Just found out why. The Pattern Skin is not included in the tgz or zip.

But the PatternSkin is in the tools/MANIFEST

I went back to the transscript from the build and found this.

/var/www/Build04x01/twikiplugins/PatternSkin/pub/TWiki/PatternSkinColorSettings/theme-colors.css does not exist - cannot copy at /var/www/Build04x01/twikiplugins/BuildContrib/lib/TWiki/Contrib/Build.pm line 953.
 at /var/www/Build04x01/twikiplugins/BuildContrib/lib/TWiki/Contrib/Build.pm line 176
        TWiki::Contrib::Build::__ANON__('/var/www/Build04x01/twikiplugins/PatternSkin/pub/TWiki/Patter...') called at /var/www/Build04x01/twikiplugins/BuildContrib/lib/TWiki/Contrib/Build.pm line 953
        TWiki::Contrib::Build::copy_fileset('TWiki::Contrib::Build=HASH(0x821fc20)', 'ARRAY(0x824eff4)', '/var/www/Build04x01/twikiplugins/PatternSkin', '/tmp/18751') called at /var/www/Build04x01/twikiplugins/BuildContrib/lib/TWiki/Contrib/Build.pm line 861
        TWiki::Contrib::Build::target_stage('TWiki::Contrib::Build=HASH(0x821fc20)') called at /var/www/Build04x01/twikiplugins/BuildContrib/lib/TWiki/Contrib/Build.pm line 1380
        TWiki::Contrib::Build::build('TWiki::Contrib::Build=HASH(0x821fc20)', 'stage') called at /var/www/Build04x01/twikiplugins/BuildContrib/lib/TWiki/Contrib/Build.pm line 843
        TWiki::Contrib::Build::target_release('TWiki::Contrib::Build=HASH(0x821fc20)') called at /var/www/Build04x01/twikiplugins/BuildContrib/lib/TWiki/Contrib/Build.pm line 1380
        TWiki::Contrib::Build::build('TWiki::Contrib::Build=HASH(0x821fc20)', 'release') called at /var/www/Build04x01/twikiplugins/BuildContrib/lib/TWiki/Contrib/Build.pm line 990
        TWiki::Contrib::Build::target_handsoff_install('TWiki::Contrib::Build=HASH(0x821fc20)') called at /var/www/Build04x01/twikiplugins/BuildContrib/lib/TWiki/Contrib/Build.pm line 1380
        TWiki::Contrib::Build::build('TWiki::Contrib::Build=HASH(0x821fc20)', 'handsoff_install') called at build.pl line 9

So it seems that one little error in the Pattern MANIFEST makes the build script skip the entire skin and because it floods pages of messages you do not see it when you build. It should stop instead so the problem can be fixed.

KJL

We went through this a couple of times before, with people flip-flopping between "stop on errors" and "don't stop, let it finish so I can test". The current condition is a compromise; it assumes the builder will check the build results. Perhaps someone could add a "stop on error" switch, or a "force" option to make it complete even if there are errors.

Is this really Urgent? i don't think so, so regrading to normal (pump it up again if you can't live with it)

CC


True. But pattern skin is not built that often because it frequently undergoes changes, or because it assumes updates to dependent plugins as well. So in this particular case errors are detected only late in the development phase.

AC

CC - no it is not urgent. It is maximum low. When I opened it it was urgent because I could not build a working release zip. Then I found the root cause and fixed the PatternSkin MANIFEST and forgot to lower the priority to low.

The only issue I have currently is that the build script writes quite a lot in the terminal (which is good) so it is easy to miss an error. It also writes a few errors which we all know to ignore (something about relative path to lib dir). An alternative could be that the script at the end says that the build finished with errors. I would have closed this bug if it was just the missing file that had been reported. But currently one small error in a manifest and an entire extension is not included and yet I missed it. We can release TWiki with this as it is and leaving the bug report as Enhancement is also OK with me.

KJL

on second thought. This bug report started with one thing and then address something else.

I will just close it with the SVN checkin I already did and open a new report when I have a better idea of how this should work.

I think it is better we focus on other things now.

KJL

ItemTemplate
Summary Twiki4.1 running from a built zip can only show classic skin. (build does not include pattern)
ReportedBy TWiki:Main.KennethLavrsen
Codebase ~twiki4
SVN Range TWiki-4.1, Sun, 05 Nov 2006, build 11901
AppliesTo Engine
Component

Priority Normal
CurrentState Closed
WaitingFor

Checkins 11922
TargetRelease minor
Edit | Attach | Watch | Print version | History: r7 < r6 < r5 < r4 < r3 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r7 - 2006-11-08 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback