• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Changes to attachments (i.e. update attributes or change comment) result in a log entry which has no "action" entry.

This in turn causes lots of "bad log lines" entries from Statistics (see also Item3089)

Store.pm should be modified with the following to provide a valid action for the change:

Index: Store.pm
===================================================================
--- Store.pm   (revision 96)
+++ Store.pm   (revision 97)
@@ -992,6 +992,7 @@
 
             $meta->putKeyed( 'FILEATTACHMENT', $attrs );
         } else {
+       $action = 'update';
             $attrs = $meta->get( 'FILEATTACHMENT', $attachment );
             $attrs->{name} = $attachment;
             $attrs->{attr} = ( $opts->{hide} ) ? 'h' : '';

TWiki:Main.DarrenElkerton

I have implemented the fix except instead of inventing yet another action type which leads to another configure option - I have used plain save. You can see it is an attribute change because unlike a normal save this shows the filename in the log.

KJL

4.1.0 released

KJL

ItemTemplate
Summary Attachment changes create bad log entries
ReportedBy TWiki:Main.DarrenElkerton
Codebase 4.0.4
SVN Range TWiki-4.1, Mon, 30 Oct 2006, build 11853
AppliesTo Engine
Component

Priority Low
CurrentState Closed
WaitingFor

Checkins 12187
TargetRelease minor
Edit | Attach | Watch | Print version | History: r5 < r4 < r3 < r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r5 - 2007-01-16 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback