• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.
MartinCleaver: webtopbar - is per web, right? I should be able to override it on a per web basis?
Drusilla: Martin, yes
MartinCleaver: viewtopbar.pattern.tmpl:%TMPL:DEF{"topbar"}%<div id="patternTopBar"><div id="patternTopBarContents">%INCLUDE{"%TWIKIWEB%.WebTopBar"}%
MartinCleaver: i.e. it ALWAYS pulls in TWIKIWEB.WebTopBar!?!
SvenDowideit_: and what foes that contain MartinCleaver ?
MartinCleaver: hmm. good q!!
MartinCleaver: nope, nothing per-web like
MartinCleaver: WebTopBar looks like it doesn't work per-web, unless I am missing something
Drusilla: The template includes WebTopBar, I'm fairly sure.
Drusilla: Oh, I'm wrong
Drusilla: It includes %TWIKIWEB%.WebTopBar.
Drusilla: easily overridden, however. viewtopbar.pattern.tmpl
Drusilla: So....change %TMPL:DEF{"topbar"}%&lt;div id="patternTopBar">&lt;div id="patternTopBarContents" %INCLUDE{"%TWIKIWEB%.WebTopBar"}%</div></div><!-- /patternTopBar-->%TMPL:END%
Drusilla: that is, change %TWIKIWEB% to %WEB%, or %BASEWEB%, or whichever the right one is
MartinCleaver: Sure, but it is non-conformant to the Web* convention working per-web.
MartinCleaver: So I've changed it in the template for the moment
Drusilla: Post a bug report


It's a PatternSkin feature.

CC


unless this is the way it's supposed to be designed, raising to requirement for realise. plus, afaict, this should be a very easy fix.

WN

What is the reported bug?

-- TWiki:Main.ArthurClemens - 25 May 2007

"WebTopBar doesn't work per-web" that is, it always uses WebTopBar instead of the WebTopBar from the current web.

WN

It was designed like this for simplicity.

A top bar for each web would mean adding a WebTopBar topic per web, and putting inside =

=. Is this occurrence worth the trouble and (little) slow down? I haven't come across the question that often on IRC or Support.

AC

i dunno, maybe i customise my sites more than most twiki installations (that's sarcasm, btw---they all look the same, but sometimes with different logos wink )... anyway,

for consistency purposes, i expect Web prefixed topics to apply web-wide. is it worth the 'trouble', sure? i'll even do it smile is it worth the little slowdown? i dunno...

WN

This is not a release blocker. The current WebTopBar works fine. It is an enhancement request.

KJL

FallBackPlugin is applicable for this problem also.

-- TWiki:Main.SteffenPoulsen - 17 Sep 2007

This is an enhancement and it could be not backwards compatible.

So this should be raised as a feature proposal - which will be considered if there is a committed developer to do it - and to ensure compatibility.

This is relatively easy to do. Arthur already answered and was clearly not in agreement so it is no longer waiting for him.

Please open the Codev proposal if someone really want this. The original reporter is for sure capable to put himself as a committed developer.

I agree with Arthur to keep a thing like this simple in the default skin - so I would not want a WebTopBar in every web per default. On the contrary - the top bar is an often tailored object so I'd rather see that a WebTopBar in Main would be a global override. And that would go straight against this proposal.

I am setting this to no action because I really do not want this one done without a Codev discussion and release meeting decision.

-- KennethLavrsen - 17 Sep 2007

I don't call this an enhancement request. WebTopBar used to b customizable. In fact, somehow, two of the webs at my company are still customizing it.

top bar for each web would mean adding a WebTopBar topic per web, and putting inside =%INCLUDE{"%TWIKIWEB%.WebTopBar"}%=.

  1. No, it wouldn't. Do it just like WebTopicEditTemplate. If the topic exists, use it. If not, use the one in TWIKIWEB
  2. So what. We have this where I work now. It's just not a big deal.

Simplicity should never trump the ability of the users to customize. At my company we have 1000 webs. WebTopBar needs to be WEB top bar.

viewtopbar.pattern.tmpl

%TMPL:DEF{"topbar"}%<div id="patternTopBar"><div id="patternTopBarContents">%CALC{$IF($EXISTS(%WEB%.WebTopBar),$NOP(%)INCLUDE{"%WEB%.WebTopBar"}$NOP(%),$NOP(%)INCLUDE{"%TWIKIWEB%.WebTopBar"}$NOP(%))}%</div></div><!-- /patternTopBar-->%TMPL:END%

-- VickiBrown - 16 Apr 2008

ItemTemplate
Summary WebTopBar doesn't work per-web
ReportedBy TWiki:Main.MartinCleaver
Codebase 4.1.2, ~twiki4
SVN Range Wed, 12 Apr 2006 build 9798
AppliesTo Extension
Component PatternSkin
Priority Enhancement
CurrentState No Action Required
WaitingFor

Checkins

TargetRelease n/a
ReleasedIn

Edit | Attach | Watch | Print version | History: r16 < r15 < r14 < r13 < r12 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r16 - 2008-04-17 - VickiBrown
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback