• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Didn't see this discussed anyway, so here goes.

I see RevCommentPlugin has some customizations in PatternSkin as is, so I wonder if we should continue this trend, or some other approach would be more suited?

Did a shot at updating CompareRevisionsAddOn and HistoryPlugin for 4.0.2, and it turns out all that is needed for default PatternSkin support is this:

Index: twikiplugins/PatternSkin/templates/viewtopicactionbuttons.pattern.tmpl
===================================================================
--- twikiplugins/PatternSkin/templates/viewtopicactionbuttons.pattern.tmpl      (revision 9760)
+++ twikiplugins/PatternSkin/templates/viewtopicactionbuttons.pattern.tmpl      (working copy)
@@ -51,5 +51,14 @@

 %TMPL:DEF{"backlinks"}%%MAKETEXT{"Backlinks"}%: <a href="%SCRIPTURLPATH%/oops%SCRIPTSUFFIX%/%WEB%/%TOPIC%?template=backlinksweb" title='%MAKETEXT{"Search the [_1] Web for topics that link to here" args="<nop>%WEB%"}%' accesskey="b">%MAKETEXT{"We&b"}%</a>, <a href="%SCRIPTURLPATH%/oops%SCRIPTSUFFIX%/%WEB%/%TOPIC%?template=backlinksallwebs" title="%MAKETEXT{"Search all webs for topics that link to here"}%" accesskey="L">%MAKETEXT{"A&ll Webs"}%</a>%TMPL:END%

+%TMPL:DEF{"history_rdiff"}%<a href="%SCRIPTURLPATH{"rdiff"}%/%WEB%/%TOPIC%?type=history" title="%MAKETEXT{"View total topic history"}%" accesskey="H" rel="nofollow">%MAKETEXT{"&History"}%</a>: %REVISIONS%%TMPL:END%

-%TMPL:DEF{"revisions"}%<span class="patternRevision"><a href="%SCRIPTURLPATH{"rdiff"}%/%WEB%/%TOPIC%?type=history" title="%MAKETEXT{"View total topic history"}%" accesskey="H" rel="nofollow">%MAKETEXT{"&History"}%</a>: %REVISIONS%</span>%TMPL:END%
+%TMPL:DEF{"history_history"}%<a href="%SCRIPTURLPATH{"oops"}%/%WEB%/%TOPIC%?template=oopshistory" title="%MAKETEXT{"View total topic history"}%" accesskey="H" rel="nofollow">%MAKETEXT{"&History"}%</a>%TMPL:END%
+
+%TMPL:DEF{"revisions_rdiff"}%%REVISIONS%%TMPL:END%
+
+%TMPL:DEF{"revisions_compare"}%%RDIFF2COMPARE{"%REVISIONS%"}%%TMPL:END%
+
+%TMPL:DEF{"revisions"}%<span class="patternRevision">%TMPL:P{context="HistoryPluginEnabled" then="history_history" else="history_rdiff"}%: %TMPL:P{context="CompareRevisionsAddonPluginEnabled" then="revisions_compare" else="revisions_rdiff"}%</span>%TMPL:END%
+
+

Unchanged behaviour if plugins are not installed, customized behaviour if installed.

Committing this in, expecting to see the patch reverted and me to be hinted of a better way to do these GUI-customizations - but there's only one way to find out smile

SVN 9761.

-- SP

History in topicaction buttons is broken. I get:

History: r23 < r22 < r21 < r20 < r19: r23 < r22 < r21 < r20 < r19

AC

Ah, yes, I see this here at develop too, I only tested with 4.0.2 and TWiki4 branch, sorry.

I'm having troubles seeing why there's a different behaviour here, though? Anyone with a better eye? I'll revert it later today if no obvious reason is found.

-- SP

Darn, I need new eyes smile

SVN 9772 should fix the double up.

-- SP

No complaints hear, closing. -- AC

ItemTemplate
Summary PatternSkin: Plugin functionality support for 4.0.3
ReportedBy TWiki:Main.SteffenPoulsen
Codebase

SVN Range Fri, 07 Apr 2006 build 9743
AppliesTo Extension
Component PatternSkin
Priority Normal
CurrentState Closed
WaitingFor

Checkins 9761 9772
TargetRelease minor
Edit | Attach | Watch | Print version | History: r10 < r9 < r8 < r7 < r6 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r10 - 2006-12-07 - ArthurClemens
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback