• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.
Refactored from Item1783

The problem

My users are so sad that the CompareRevisionsAddOn? no longer works after upgrading to 4.0.2. It gives a diff display which is very superior to the rdiff display. Since 4.0.2 we just get a blank screen when trying to use it.

The solution provided by TWiki:Main.SteffenPoulsen and tested by TWiki:Main.KennethLavrsen

From 1783

QUOTE Took a quick shot at CompareRevisionsAddOn, attached updated versions of interweave and compare.

Never used this plugin before, so I don't know if it displays as expected now, but it displays something. Perhaps you will SVN commit / re-package / talk to author if it works OK, KJL?

Don't know about the view_cra, I believe the change should be applied to viewtopicactionbuttons.pattern.tmpl now, if wanted. If each of the single "<" should go to compare instead of rdiff, of course it's in lib/TWiki/UI/View.pm the rdiff should be changed to compare - though that doesn't seem to be suggested in the plugin topic anywhere).

-- SP

UNQUOTE

Hey. It works. Wow. Thanks. You just earned yet another beer, Steffen.

I will checkin the changes and contact author.

-- KJL

Nice combo, this. Updated CompareRevisionsAddOn and HistoryPlugin to be 4.0.2 compatible, take them for a spin.

TODO: Add screenshots to SVN, add wikipedia-like javascript to HistoryPlugin.

SVN 9759.

-- SP

So should viewtopicactionbuttons_cra be merged with viewtopicactionbuttons?

AC

It hope it already is, but would appreciate a check on it. I will remove the file from the plugin at 4.0.3 or new PatternSkin release (could also be removed and replaced with some doc explaining to get it from SVN, but for now it's a local copy in the .zip).

Btw: Saw you noticed the very black table in the IRC log last night, would be happy if something could be done about that, I've given up on that [hint, hint] smile

-- SP

  • No, viewtopicactionbuttons_cra is not yet merged.
    • Huh! There is template-specific stuff in Compare.pm (my $revisions). Not suitable for other skins, and it may break easily. It is even out of tune with pattern skin already.
    • I would not put the 2 compare links in between their own separators, like | History | Side-by-side |, but: | History: Mixed, Side by side |
    • Why is the newest version at the left, not at the right as rdiff does? The right seems more logical to me. See also the Wikipedia compare with the newest version at the right.
    • When on the side-by-side comparison page, why is there a link "History" that points to rdiff? Why not keep the links "Mixed" and "Side-by-side" with the current 'view' in selected state (not a link)?
  • This addon should ship with CompareRevisionsAddOnDemoTopic.txt,v to actually see the differences.
  • Shouldn't pattern skin's More page be updated as well with CompareRevisions options (compare instead of rdiff)
  • I will look at the table. It just has a very black border that is out of tune. It appears that the borders are defined by table cells. I need a css class around the table! So I can define in my stylesheet .compareRevisionsTable table.
  • What's a wikipedia-like javascript?

AC

I think it would be even better (simpler) if the History link would stay as it is (for the user) while only the link changes to a "Compare" page with 2 tabs: "Mixed" and "Side by side". The compare page opens the tab that the user viewed last (and is read from a cookie).

That way we keep the bottom links simple (without users having to know what is "Mixed" or "Side by side". And the interface stays consistent, which is nice for skin builders.

AC

Is this still live? there seems to have been a lot of checkins, but no feedback. Assigning to Kenneth for closure.

CC

Closing

KJL

ItemTemplate
Summary CompareRevisionAddOn template updates for 4.0.2
ReportedBy TWiki:Main.KennethLavrsen
Codebase

SVN Range Mon, 27 Mar 2006 build 9563
AppliesTo Extension
Component CompareRevisionAddOn
Priority Normal
CurrentState Closed
WaitingFor

Checkins 9751 9752 9753 9754 9755 9759 9760 9791 9792 9793 9794 9796 9806 9807 9808 9811 9827 9842 9843
TargetRelease n/a
ReleasedIn

Edit | Attach | Watch | Print version | History: r31 < r30 < r29 < r28 < r27 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r31 - 2007-02-04 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback