• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

The fix for the email padding problem that was introduced just after 4.0.2 release has created an annoying problem.

Each time someone looks at a twiki page with an email address I get this error in the apache error_log

[Fri Apr 07 00:48:00 2006] [error] [client 87.6.68.19] [Fri Apr  7 00:48:00 2006] view: Use of uninitialized value in substitution (s///) at /usr/local/apache2/twiki/lib/TWiki/Render.pm line 741., referer: http://motion.sourceforge.net/

I assume the text is defined in links where a mailto is a html tag defined mailto with a displayed text so when an email address is just displayed and turned into a mailto by TWiki the $text is not defined.

So line 741 just becomes

if ( defined($text) ) {
    $text =~ s/(@\w*)/$1$TWiki::cfg{AntiSpam}{EmailPadding}/;
}

Need to test that is the case before committing.

-- KJL

After some testing I found the reason.

I had links written as mailto:someone@domain.com

And this is not official syntax. But I see no harm in defensive programming in this case. I may not be the only luser writing an email address this way. But I now declassify the priority to low.

Unless someone swears at me meanwhile I will commit the "if defined" fix this weekend after having run it for a day on my Motion TWiki.

-- KJL

SVN 10017 CC happened to also fix this one getting $text defined before doing regexes on it. Changed title of bug report so it better describes what was fixed for the release note of 4.0.3.

-- KJL

ItemTemplate
Summary Mailto links written as mailto:address causes flooding with warning messages about uninitialized value
ReportedBy TWiki:Main.KennethLavrsen
Codebase 4.0.2
SVN Range Mon, 27 Mar 2006 build 9563
AppliesTo Engine
Component

Priority Low
CurrentState Closed
WaitingFor

Checkins

TargetRelease patch
Edit | Attach | Watch | Print version | History: r3 < r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r3 - 2006-05-08 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback