• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

This package broken because it uses the preference values of the web it has been called from. Either the preferences cache must be refreshed using the web to be published or the publish form must be in the web that is to be published.

Oh, already reported in Item1791.


Other issues:

  • css files may contain urls to other css and images that need to be archived as well
  • html in the contrib topic text
  • hardcoded reference to plain.pattern skin

Fixed in SVN 9695.

WebPreferences issue still unsolved.


Following links in CSS files is not going to happen. That could end up crawling the whole web.

I have no idea what "html in the contrib topic text" is meant to mean

Where is the hardcoded reference?

CC


> html in the contrib topic text"

I fixed the markup which was so broken that it messed up the skin.

> Where is the hardcoded reference?

It used print.pattern reading the view template for no obvious reason.

> Following links in CSS files is not going to happen. That could end up crawling the whole web.

Ehm, no. Your browser terminates loading a page.

MD.


The only obvious way to solve the WebPreferences issue is to do call view separately, that is: each page is rendered by a fresh twiki engine.

MD.

Actually, it's a lot simpler than that. The form action needs to not specify the web, so that the web url parameters is used instead.

SVN 9713

CC


No, it is not that simple. This is not only about WebPreferences but also about preferences and variables set in the topics. They are not read and not reverted for the next topic. Just imagine about plugins that have an "inner memory", e.g. the SpreadSheetPlugin etc.

Every topic has to be fetched by a fresh twiki engine.

Reopening this bug report.

MD


Here's a patch that creates a new preferences object for each topic:
+    my $twiki = $TWiki::Plugins::SESSION;
+    $twiki->{prefs} = new TWiki::Prefs($twiki);
+    $twiki->{prefs}->pushGlobalPreferences();
+    $twiki->{prefs}->pushPreferences($TWiki::cfg{UsersWebName}, $wikiName, 'USER '.$wikiName);
+    $twiki->{prefs}->pushWebPreferences($web);
+    $twiki->{prefs}->pushPreferences($web, $topic, 'TOPIC');
+    $twiki->{prefs}->pushPreferenceValues('SESSION', $twiki->{client}->getSessionValues());

btw. you previous checkin broke rewriting the urls.

MD

Micha has fixed all the outstanding problems, we think.

SVN 9726

CC

ItemTemplate
Summary PublishContrib broken
ReportedBy TWiki:Main.MichaelDaum
Codebase

SVN Range Mon, 27 Mar 2006 build 9563
AppliesTo Extension
Component PublishContrib
Priority Urgent
CurrentState Closed
WaitingFor

Checkins 9695 9713 9714 9725 9726
TargetRelease n/a
Edit | Attach | Watch | Print version | History: r13 < r12 < r11 < r10 < r9 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r13 - 2006-04-06 - CrawfordCurrie
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback