• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

After switching to TWiki4 and enabling {IDsInUrls} I noticed that the topic links included in the emails sent out by the mailnotify script were invalid. For instance:

http://shake200.esscc.uq.edu.au/twiki/bin/?TWIKISID=04ed1ee4f8f4077a543fa8b19ef1fa4a

Instead of:

http://shake200.esscc.uq.edu.au/twiki/bin/view/ESSCC/WebNotify

Turning IDsInURLs off again resulted in the correct links being used in the E-mails. As such I appear to be able to replicate this on my install at will.

Here's the fix I created:

lib/TWiki/Contrib/MailerContrib/Change.pm
***************
*** 127,132 ****
--- 127,133 ----
          }
      }
      $html =~ s/%REVISION%/$frev/g;
+     $html = $this->{SESSION}->handleCommonTags( $html, $this->{WEB}, $this->{TOPIC} );
      $html = $this->{SESSION}->{renderer}->getRenderedVersion( $html );
      $html =~ s/%TEXTHEAD%/$this->{HTML_SUMMARY}/g;

It appears that getRenderedVersion called without a call the handleCommonTags corrupts the %SCRIPTURL{"view"}% tag before it can be processed. This file is unmodified in 4.0.4 but I haven't tried in that version.


Good catch, thanks. Not sure why it took so long to get to this :-/

CC

4.1.0 released

KJL

ItemTemplate
Summary MailerContrib: Mailnotify generates bogus links with {IDsInURLs} configure option
ReportedBy TWiki:Main.StephenGordon
Codebase 4.0.1, 4.0.2
SVN Range 4.0.1
AppliesTo Extension
Component MailerContrib
Priority Normal
CurrentState Closed
WaitingFor

Checkins 11650
TargetRelease minor
Edit | Attach | Watch | Print version | History: r9 < r8 < r7 < r6 < r5 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r9 - 2007-01-16 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback