• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

There are (at least) two problems:

    if( !scalar( @posValues ) &&
         $store->topicExists( $web, $topic ) ) {

returns false if there are no options. It should be

            if( (!scalar( @posValues ) || scalar(@posValues) == 0)) {

Second, $topic may actually be $web.$topic and in that case $topic has to be split

I've attempted to fix both of these problem and it passes my brief testing. I would very much appreciate it if someone would look over the code and make sure I've done things right.

SVN 9577


Meredith forgot to change state. I am beginning to understand how it is to be my wife and clean up after me :-P

It was a last minute fix but I spent two hours testing it very carefully and it does the job well and does not break the previous functionality. And I have personally missed that this worked for years so I am very thankful for the fix.

KJL


I have to lol at your first comment but... I wasn't comfortable changing the state to "Waiting for Release" until it had been tested more thoroughly. Maybe we need another state, "Please test"?

I'm really glad that it works and that someone besides me appreciates the fix.

ML

Closed with release of 4.0.2

KJL

ItemTemplate
Summary Form.pm fails when the name field is [[Topic][fieldname]] for controls
ReportedBy TWiki:Main.MeredithLesly
Codebase

SVN Range 9576
AppliesTo Engine
Component

Priority Urgent
CurrentState Closed
WaitingFor

Checkins 11161 11163 9577 9578
TargetRelease patch
Edit | Attach | Watch | Print version | History: r9 < r8 < r7 < r6 < r5 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r9 - 2006-04-01 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback