• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Both Sven and I made each our implementation of the same thing because we both found the asthetics of Pattern a little nice this way.

I ended up implementing Sven's solution myself because it worked the best when you have a long bread crumb and or a narrow window.

I have run with this on my Motion TWiki for 2 weeks now and also at the Motorola TWiki for one week. And I have not spotted any negative effects of the change.

The change: in view.pattern.tmpl

change

%TMPL:DEF{"topicpathinfo"}%<div class="patternHomePath"><span class="patternHomePathTitle">%MAKETEXT{"You are here"}%: </span>[[%MAINWEB%.%HOMETOPIC%][%WIKITOOLNAME%]] %TMPL:P{"topicpathseparator"}% <a href="%SCRIPTURLPATH%/view%SCRIPTSUFFIX%/%WEB%/%HOMETOPIC%"><img src="%ICONURLPATH{web-bg-small}%" border="0" alt="" width="13" height="13" style="background-color:%WEBBGCOLOR%" /> %MAKETEXT{"[_1] Web" args="<nop/>%WEB%"}%</a> %META{"parent" nowebhome="on" prefix=" %TMPL:P{"topicpathseparator"}% " suffix=""}% %TMPL:P{"topicpathseparator"}% <span title="%WEB%.%TOPIC%"><nop>%TOPIC%</span>%TMPL:P{"revinfo"}%</div><!-- /patternHomePath-->%TMPL:END%

to

%TMPL:DEF{"topicpathinfo"}%<div class="patternHomePath"><span class="twikiRight">%TMPL:P{"revinfo"}%</span>[[%MAINWEB%.%HOMETOPIC%][%WIKITOOLNAME%]] %TMPL:P{"topicpathseparator"}% <a href="%SCRIPTURLPATH%/view%SCRIPTSUFFIX%/%WEB%/%HOMETOPIC%"><img src="%ICONURLPATH{web-bg-small}%" border="0" alt="" width="13" height="13" style="background-color:%WEBBGCOLOR%" /> %MAKETEXT{"[_1] Web" args="<nop/>%WEB%"}%</a> %META{"parent" nowebhome="on" prefix=" %TMPL:P{"topicpathseparator"}% " suffix=""}% %TMPL:P{"topicpathseparator"}% <span title="%WEB%.%TOPIC%"><nop>%TOPIC%</span></div><!-- /patternHomePath-->%TMPL:END%

KJL

Committed to SVN on both DEVELOP and TWiki4

SVN 9353 and 9354

KJL

Hmm. You are applying a last minute change while I was away...

I had a reason to put the revinfo at the left. You haven't spotted negative side effects because you haven't framed the page. With a smaller page, the breadcrumb and the revinfo collide in not so nice way.

Please revert this, and make it a cookbook item.

AC

There is something I do not understand here.

The change I made clearly looks better on the standard Pattern skin as distributed with TWiki. Which is without the frame! And should be without the frame.

So you want one cook book that describes how to make a framed version.

And you want another cook book which tells how to make the REVINFO nice on the standard skin.

Why not describe in the cookbook for framed Pattern skin how to change the REVINFO to the appended presentation?

If you insist I will revert for sure. At the end it is all a matter of taste.

But I think you will find that most think it is nice to have the REVINFO on the right in the standard skin and I think it collides in a nice way the way Sven implemented it. My own implementation did not collide well which is why I gave it up in favour of Sven's solution.

I am at work now as I write this and cannot revert it from here - otherwise I would now. But think about it one more time please. If there is no reply from you I revert.

KJL

Reverted - though I do not agree.

SVN 9399 and 9400.

I will keep the report open but tag it to later release - minor.

I will not write a cook book that tells how to hack a template. There should be a style sheet fix for it and that is why I keep the bug open.

KJL

I don't have a problem with suggestions for a better interface. But I am bothered when a change is commited for a release that is pending without me knowing.

But now I do know, I must say it does look better, and that the wrapping is much nicer than what I had achieved and discarded.

I want to keep the "You are here:" though.

AC

I removed the You are here: to get more space for the breadcrumb before the it starts wrapping. But it is OK that it is there. I do not mind at all.

I also made an implementation and it looked awful when it folded.

But TWiki:Main.SvenDowideit is the guy to give the credit for the good looking solution. Under normal circumstances we would have asked you to implement it. But since you were on vacation I decided to implement it so we could test some test exposure before release. And I asked for advice on #twiki first before I committed the change and I was encouraged to do it.

Thanks for checking in the improved improvement again.

I am changing the status to Waiting for Release.

AC checked in SVN 9401 and 9402

KJL

ItemTemplate
Summary REVINFO in PatternSkin looks better if right aligned instead of appended to bread crumb.
ReportedBy TWiki:Main.KennethLavrsen
Codebase

SVN Range Mon, 13 Mar 2006 build 9258
AppliesTo Extension
Component PatternSkin
Priority Low
CurrentState Closed
WaitingFor

Checkins 9353 9354 9399 9400 9401 9402
TargetRelease n/a
Edit | Attach | Watch | Print version | History: r9 < r8 < r7 < r6 < r5 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r9 - 2006-04-01 - CrawfordCurrie
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback