• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

These plugin templates need to be updated:

  • NotificationPlugin: changes-srg-html.pattern.tmpl
    • Plugin does not work on Dakar: template not updated
  • CompareRevisionsAddOn:
    • compare.pattern.tmpl
    • interweave.pattern.tmpl
    • Plugin does not work on Dakar: template not updated
      • Not correct. It was updated for 4.0.1. But needs updating again for 4.0.2 because of template changes. But as far as I can tell the plugin is not up to date on SVN.
  • EditTablerowPlugin: editTableRow.pattern.tmpl
    • Plugin does not work on Dakar: template not updated
  • SearchEnginePluceneAddOn: plucsearch.pattern.tmpl
    • Too many CPAN dependencies to test: template not updated

AC


My users are so sad that the CompareRevisionsAddOn no longer works after upgrading to 4.0.2. It gives a diff display which is very superior to the rdiff display. Since 4.0.2 we just get a blank screen when trying to use it.

The author does not seem keen to update it. Maybe he has trouble understanding the now very complex and very fragmented pattern skin template system.

I cannot blame him because I do not understand it either.

KJL


When I am tired I get very grumpy when I read this kind of message. Can't please them all can I?

But anyway, I can update the plugin templates if the plugins work on TWiki 4.0.2. That's why I had created this Item in the first place.

AC

Took a quick shot at CompareRevisionsAddOn, attached updated versions of interweave and compare.

Never used this plugin before, so I don't know if it displays as expected now, but it displays something. Perhaps you will SVN commit / re-package / talk to author if it works OK, KJL?

Don't know about the view_cra, I believe the change should be applied to viewtopicactionbuttons.pattern.tmpl now, if wanted. If each of the single "<" should go to compare instead of rdiff, of course it's in lib/TWiki/UI/View.pm the rdiff should be changed to compare - though that doesn't seem to be suggested in the plugin topic anywhere).

-- SP

Thanks Steffen. I will test it.

Arthur. It was not my meaning to make anyone grumpy. I had tried to understand how to make these templates work for hours when I opened the bug report and I could not make anything work. It is quite complicated.

Will report back when I have tested. I do not personally use the view_cra. I only use the interweave template by having URLs in a change history table which are the same as the rdiff except rdiff is replaced by compare in the URL.

-- KJL

Hey. It works. Wow. Thanks. You just earned yet another beer, Steffen.

(And there is beer for you too Arthur for the wonderful Pattern Skin.)

I will checkin the changes and contact author.

To get better traceability between bugs and SVN I have refactored the CompareRev addon to Item2064

-- KJL

I was just reacting on the information-sparse "I do not understand it either". It would help me if you were more specific. What is missing? Documentation for each template?

AC

It is difficult to understand the template for for example view because it is difficult to get an overview. The template consists of many included templates that again include another template. It is simply difficult to get the overview.

I have since learned WHY it is so complicated. I know it adds a lot of flexibility so it is easier to modify only parts. But it is at the expense of overview if for example the vew template was just ONE template file which would be the other extreme.

I do not have an easy answer to how else it should be done better.

Seeing this bug report - which I think should have been closed - I'd better check that the addon still works.

KJL

CompareRevisions works still.

The other plugins listed have since this report been updated. I am closing this.

KJL

ItemTemplate
Summary Plugin template updates after pattern skin update
ReportedBy TWiki:Main.ArthurClemens
Codebase

SVN Range Fri, 03 Mar 2006 build 9056
AppliesTo Extension
Component PatternSkin
Priority Normal
CurrentState Closed
WaitingFor

Checkins 9152
TargetRelease patch
Topic attachments
I Attachment History Action Size Date Who Comment
Compressed Zip archivezip cra_pattern_402_templates.zip r1 manage 2.1 K 2006-04-08 - 21:17 SteffenPoulsen interweave / compare, 4.0.2 compatible
Edit | Attach | Watch | Print version | History: r12 < r11 < r10 < r9 < r8 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r12 - 2006-12-12 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback