• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

There is a template action defined in CommentPluginTemplate

If you edit the topic and save again the ActionTrackerPlugin turns the %ACTION into an actual dummy action leaving the template destroyed.

The only way I have found to repair it is to edit the template doc with an ASCII editor.

KJL


It looks like the plugin's beforeSaveHandler is the culprit. It calls the internal routine _addMissingAttributes to add, well, missing attributes. To do that, it scans the text, but fails to check for verbatim blocks. Unfortunately at this stage there's no takeOutBlocks available.

I'll prepare a testcase (ActionTrackerPlugin is one of the few which features unit tests) and a makeshift patch this week, usually there's a kind soul who either repairs the patch or checks it in.

-- TWiki:Main.HaraldJoerg

After some experimenting I found a "work around" which could be SVN'ed right away.

%TMPL:DEF{OUTPUT:action}%%POS:BEFORE%%AC%NOP%TION{who="%URLPARAM{"who"}%" due="%URLPARAM{"due"}%"}% %URLPARAM{"comment" newline="<br />"}%<br />- Created by %WIKIUSERNAME%, %SERVERTIME%

Note that placing a %NOP% inside the %ACTION% tag is the way that works.

You always had to do extra protection of ACTION also in Cairo but because of the improved interpretion of TWikiVariables from inside out the old %ACTION%NOP%{ no longer prevents the Action Tracker from acting on the tag. But placing the %NOP% in the middle of ACTION does.

So a quick and in my view acceptable fix is to change this in CommentPluginTemplate.

KJL

Agreed, from my point of view. Especially since I don't have to write a test case for that fix smile Yet we need someone to check in the fix, don't we? (It's attached, just in case)

TWiki:Main.HaraldJoerg

CC has checked it in (rev 9041), and it is marked for 4.0.2, so I'm closing it. Many thanks! I know that the CommentsPluginTemplate is thought to be readonly, but have observed that many twikizens are using an edit/save cycle instead of viewing in raw mode or edit/cancel. So the fix helps to make it more robust against user errors, which is A Good Thing.

TWiki:Main.HaraldJoerg

ItemTemplate
Summary ActionTrackerPlugin - impossible to save a comment template for it
ReportedBy TWiki:Main.KennethLavrsen
Codebase

SVN Range Sun, 26 Feb 2006 build 8945
AppliesTo Extension
Component ActionTrackerPlugin
Priority Urgent
CurrentState Closed
WaitingFor

Checkins 9041
TargetRelease major
Topic attachments
I Attachment History Action Size Date Who Comment
Unknown file formatdiff item1749.diff r1 manage 0.8 K 2006-03-02 - 23:23 HaraldJoerg Protect %ACTION{}% tags in CommentPluginTemplate
Edit | Attach | Watch | Print version | History: r8 < r7 < r6 < r5 < r4 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r8 - 2006-03-04 - CrawfordCurrie
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback