• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

The current code says:

              # If this is a closing }%, try to rejoin the previous
              # tokens until we get to a valid tag construct. This is
!             # a bit of a hack, but it's hard to think of a better
!             # way to do this without a full parse that takes % signs
!             # in tag parameters into account.

It does not handle nested %{...}% tags properly, such as

%WEBLIST{"<span style=\"background-color:%VAR{\"WEBBGCOLOR\" web=$qweb}%\">..." ...}%

I am attaching to this item a patch for the current 4.0.0 release to fix this.

Included in this patch is a fix for another issue that I found annoying: a selection is set to '' rather than the current web when it was not specified in the params.


Sorry, Robert, no cigar. Your patch probably does the sensible thing and correctly address matched braces. Unfortunately I believe it also breaks compatibility with Cairo (TWiki20040904), which does not match braces. Since "compatilibility" is a touchstone, that means we have to reproduce even the broken bits of Cairo, otherwise TWikiApplications will break.

I went through innumerable revisions of this code to reach the current delicate level of compatibility frown

CC

Are there any topics that list a number of cases supported / not supported in the two scenarios, showing the interest in keeping compatibility?

-- SP


No, but there are a range of testcases in the TestCases web and in the unit tests that must pass for compatibility to be maintained. The TWiki Mission just says "jump", it doesn't say "how high?"

CC

ItemTemplate
Summary processing nested %{...}% Tags
ReportedBy TWiki:Main.RobertWhelton
Codebase

SVN Range Sun, 29 Jan 2006 build 8586
AppliesTo Engine
Component

Priority Normal
CurrentState No Action Required
WaitingFor

TargetRelease major
Topic attachments
I Attachment History Action Size Date Who Comment
Unknown file formatpatch TWiki-4.0.0-lib-TWiki.pm.patch r1 manage 3.9 K 2006-02-02 - 19:03 RobertWhelton patch file
Edit | Attach | Watch | Print version | History: r6 < r5 < r4 < r3 < r2 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r6 - 2006-02-20 - CrawfordCurrie
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback